Page MenuHomePhabricator

enlight (Vadim Macagon)
Developer

Projects

User does not belong to any projects.

User Details

User Since
May 4 2015, 5:00 AM (233 w, 18 h)

Recent Activity

Aug 9 2017

enlight committed rL310488: Fix PlatformPythonTestCase.test_platform_list for the build bots.
Fix PlatformPythonTestCase.test_platform_list for the build bots
Aug 9 2017, 8:50 AM
enlight committed rL310452: Expose active and available platform lists via SBDebugger API.
Expose active and available platform lists via SBDebugger API
Aug 9 2017, 2:21 AM
enlight closed D35760: Expose active and available platform lists via SBDebugger API by committing rL310452: Expose active and available platform lists via SBDebugger API.
Aug 9 2017, 2:21 AM · Restricted Project

Aug 2 2017

enlight committed rL309803: Fix ProcessAPITestCase.test_get_process_info.
Fix ProcessAPITestCase.test_get_process_info
Aug 2 2017, 3:12 AM

Aug 1 2017

enlight added a comment to D35760: Expose active and available platform lists via SBDebugger API.

I've updated the patch with your suggestions @jingham

Aug 1 2017, 12:44 AM · Restricted Project
enlight committed rL309664: Expose process instance info via SB API.
Expose process instance info via SB API
Aug 1 2017, 12:35 AM
enlight closed D35881: Expose process instance info via SB API by committing rL309664: Expose process instance info via SB API.
Aug 1 2017, 12:35 AM

Jul 26 2017

enlight updated the diff for D35760: Expose active and available platform lists via SBDebugger API.
  • Renamed SBDebugger::GetAvailablePlatformAtIndex() to GetAvailablePlatformInfoAtIndex().
  • Changed PlatformPythonTestCase.test_platform_list to select one of the available platforms instead of hardcoding the remote-linux platform.
Jul 26 2017, 7:34 AM · Restricted Project
enlight created D35881: Expose process instance info via SB API.
Jul 26 2017, 2:10 AM

Jul 23 2017

enlight added a comment to D35760: Expose active and available platform lists via SBDebugger API.

Thanks for the review Jim, but I only see the testing suggestion, could you elaborate on the other two issues?

Jul 23 2017, 7:53 PM · Restricted Project

Jul 22 2017

enlight updated the diff for D35760: Expose active and available platform lists via SBDebugger API.

Update packages/Python/lldbsuite/test/python_api/default-constructor/sb_debugger.py

Jul 22 2017, 7:43 AM · Restricted Project

Jul 21 2017

enlight added reviewers for D35760: Expose active and available platform lists via SBDebugger API: jingham, clayborg.
Jul 21 2017, 10:56 PM · Restricted Project
enlight updated the diff for D35760: Expose active and available platform lists via SBDebugger API.

Add docstrings to SWIG bindings.

Jul 21 2017, 10:09 PM · Restricted Project
enlight created D35760: Expose active and available platform lists via SBDebugger API.
Jul 21 2017, 9:21 PM · Restricted Project

Nov 7 2016

enlight added a comment to D26124: [LLDB-MI] Escape MI output in a more consistent manner.

@ki.stfu Are you OK with this going in?

Nov 7 2016, 7:24 PM

Nov 2 2016

enlight added a comment to D26124: [LLDB-MI] Escape MI output in a more consistent manner.

Thanks for the review. AddSlashes is still used in a couple of places (but not for escaping MI output), so I'll leave it be for now.

Nov 2 2016, 7:29 PM

Oct 29 2016

enlight updated D26124: [LLDB-MI] Escape MI output in a more consistent manner.
Oct 29 2016, 10:26 PM
enlight retitled D26124: [LLDB-MI] Escape MI output in a more consistent manner from to [LLDB-MI] Escape MI output in a more consistent manner.
Oct 29 2016, 10:21 PM

Oct 14 2016

enlight committed rL284231: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
[LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class
Oct 14 2016, 6:07 AM
enlight closed D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class by committing rL284231: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 14 2016, 6:07 AM
enlight added inline comments to D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 14 2016, 2:04 AM
enlight updated the diff for D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.

Rename kUnresolvedValue back to kUknownValue.

Oct 14 2016, 2:03 AM
enlight updated the diff for D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.

Renamed placeholder c-strings.

Oct 14 2016, 12:51 AM

Oct 13 2016

enlight added inline comments to D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 13 2016, 11:14 PM
enlight retitled D25592: [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class from to [LLDB-MI] Minor cleanup of CMICmnLLDBUtilSBValue class.
Oct 13 2016, 10:40 PM

Oct 12 2016

enlight committed rL284100: Fix Python binding generation build step on Windows.
Fix Python binding generation build step on Windows
Oct 12 2016, 9:36 PM
enlight closed D25396: Fix Python binding generation build step on Windows by committing rL284100: Fix Python binding generation build step on Windows.
Oct 12 2016, 9:36 PM · Restricted Project

Oct 11 2016

enlight added a comment to D25486: Fix lookup path for lldb-mi.

Heh. It just occurred to me that this is probably the reason why all of the lldb-mi tests fail on Windows. Because .exe is not appended. I'm not ready to turn that on and deal with all the failures just yet, but for now can you please add a #TODO right above this that says "Append .exe on Windows"

Oct 11 2016, 8:12 PM
enlight added a comment to D25396: Fix Python binding generation build step on Windows.

@zturner Are you good with this going in?

Oct 11 2016, 6:40 PM · Restricted Project

Oct 8 2016

enlight retitled D25396: Fix Python binding generation build step on Windows from to Fix Python binding generation build step on Windows.
Oct 8 2016, 8:00 AM · Restricted Project

Oct 30 2015

enlight retitled D14197: Handle the options and parameters separator in every MI command from Handle the option and parameter separator in every command. to Handle the options and parameters separator in every MI command.
Oct 30 2015, 6:59 AM

Oct 22 2015

enlight added a comment to rL250335: Fix codesign command with cmake..

It seems like it should be possible to conditionally enable this using CMAKE_VERSION. However that just means anyone who's silly enough to use an older CMake version may run into the issue this patch attempts to address, so arguably the proper fix is to bump up the CMake version requirement instead. Should probably run this by lldb-dev first.

Oct 22 2015, 5:35 AM

Oct 21 2015

enlight added a comment to rL250335: Fix codesign command with cmake..

I believe LLVM requires CMake 2.8.12 or later (at least that was the case
when I looked three weeks ago).

Oct 21 2015, 8:37 PM

Oct 13 2015

enlight accepted D13404: Teach CMake to find versions of Python != 2.7.
Oct 13 2015, 9:53 AM
enlight committed rL250175: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in….
Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in…
Oct 13 2015, 9:33 AM
enlight closed D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows by committing rL250175: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in….
Oct 13 2015, 9:32 AM

Oct 11 2015

enlight added a comment to D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows.

I've looked at the path separator issue you've mentioned earlier in D13201, and I think it's fine as is. All those paths with the forward slashes end up in a FileSpec, which converts forward slashes to backward slashes before passing them through to any Win32 APIs, and FileSpec::GetPath() also converts slashes by default.

Oct 11 2015, 9:23 AM
enlight retitled D13636: Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows from to Symbols::LocateExecutableSymbolFile() shouldn't try to look for files in /usr/lib/debug on Windows.
Oct 11 2015, 8:57 AM

Oct 8 2015

enlight added a comment to D13404: Teach CMake to find versions of Python != 2.7.

Hi Zach,

Oct 8 2015, 5:59 AM

Oct 7 2015

enlight retitled D13520: Make CMake display more readable paths to Python binaries on Windows from to Make CMake display more readable paths to Python binaries on Windows.
Oct 7 2015, 10:40 AM

Oct 5 2015

enlight added inline comments to D13404: Teach CMake to find versions of Python != 2.7.
Oct 5 2015, 9:35 PM

Oct 4 2015

enlight updated the diff for D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile().

Added a couple of unit tests, the Windows-specific cleanups will be submitted in a separate patch.

Oct 4 2015, 8:34 AM

Oct 3 2015

enlight added inline comments to D13404: Teach CMake to find versions of Python != 2.7.
Oct 3 2015, 12:39 AM
enlight added inline comments to D13404: Teach CMake to find versions of Python != 2.7.
Oct 3 2015, 12:19 AM

Oct 2 2015

enlight added a comment to D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator.

That looks fine to me. CMake prints those messages during the configuration step, at that point the generator expressions haven't been expanded yet. I could prettify those messages a bit to read: Found PythonLibs: C:/Python27_LLDB/x86/libs/python27_d.lib and C:/Python27_LLDB/x86/libs/python27.lib.

Oct 2 2015, 10:39 PM

Sep 30 2015

enlight updated the diff for D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator.

Added an explanation of the generator expression used in this patch.

Sep 30 2015, 12:27 AM

Sep 29 2015

enlight planned changes to D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator.

I'll submit a revised patch that contains an explanation of the generator expressions to aid future maintainers/contributors.

Sep 29 2015, 11:04 PM
enlight added inline comments to D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator.
Sep 29 2015, 10:47 AM
enlight added a parent revision for D13237: Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir: D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator.
Sep 29 2015, 3:07 AM
enlight added a child revision for D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator: D13237: Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir.
Sep 29 2015, 3:07 AM
enlight retitled D13237: Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir from to Add a Post-Build Event on Windows to copy the correct custom Python DLL to the LLDB binaries dir.
Sep 29 2015, 3:00 AM
enlight retitled D13234: Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator from to Use the correct Python lib for each build configuration generated by the Visual Studio CMake generator.
Sep 29 2015, 1:51 AM

Sep 28 2015

enlight added a comment to D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile().

I've updated the summary with the scenario. I don't know how one would go about writing a test for this, mixed platform remote debugging is a bit finicky.

Sep 28 2015, 2:16 AM

Sep 27 2015

enlight updated D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile().
Sep 27 2015, 11:50 PM
enlight updated subscribers of D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile().
Sep 27 2015, 11:07 PM
enlight retitled D13201: Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile() from to Fix segmentation fault in lldb_private::Symbols::LocateExecutableSymbolFile().
Sep 27 2015, 10:46 PM

Sep 21 2015

enlight added inline comments to D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run.
Sep 21 2015, 7:35 PM

Sep 19 2015

enlight updated subscribers of D12968: Fix for lldb-mi crash in Listener code if -exec-abort MI command was invoked without getting process stopped.
Sep 19 2015, 11:40 PM
enlight added a comment to D12977: LLDB MI addition for getting process stopped at first instruction right after launch via -exec-run.

According to the GDB-MI spec the exec-run command already has a start option. Support for the start option can be detected by checking for exec-run-start-option in the list of features returned by the list-features command. So, what's the rationale for diverging from the spec in this case?

Sep 19 2015, 10:48 PM

Jun 5 2015

enlight retitled D10299: [LLDB-MI] Properly detect missing mandatory arguments to MI commands from to [LLDB-MI] Properly detect missing mandatory arguments to MI commands.
Jun 5 2015, 11:45 PM

May 7 2015

enlight retitled D9595: Make LLDB-MI tests wait for LLDB-MI to start up before sending any MI commands from to Make LLDB-MI tests wait for LLDB-MI to start up before sending any MI commands.
May 7 2015, 9:20 PM

May 6 2015

enlight added inline comments to D9470: Fix LLDB-MI -data-read-memory-bytes command to comply with GDB/MI spec.
May 6 2015, 8:50 PM

May 5 2015

enlight updated the diff for D9470: Fix LLDB-MI -data-read-memory-bytes command to comply with GDB/MI spec.

Removed the line requested, added a full description of the command to MIExtensions.txt.

May 5 2015, 12:27 AM

May 4 2015

enlight retitled D9470: Fix LLDB-MI -data-read-memory-bytes command to comply with GDB/MI spec from to Fix LLDB-MI -data-read-memory-bytes command to comply with GDB/MI spec.
May 4 2015, 5:56 AM