This is an archive of the discontinued LLVM Phabricator instance.

[lldb-tests] Add compiler version check in TestFunctionStarts
ClosedPublic

Authored by fdeazeve on Oct 18 2022, 8:05 AM.

Details

Summary

This test requires compiling its input program without debug
information. To do so, it uses certain Makefile variables that are never
populated with custom libcxx paths (if present). Doing so would not
necessarily be correct, since we cannot guaranteed that said standard
library has debug symbols or not.

As such, we keep using the system libraries but to disable the tests in
clang versions that are too old to work with more modern system
libraries, as in the case of the lldb-matrix bot.

Diff Detail

Event Timeline

fdeazeve created this revision.Oct 18 2022, 8:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 8:05 AM
fdeazeve requested review of this revision.Oct 18 2022, 8:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 8:05 AM
fdeazeve updated this revision to Diff 468551.Oct 18 2022, 8:10 AM

Fixed typos in commit message

aprantl accepted this revision.Oct 18 2022, 8:51 AM
This revision is now accepted and ready to land.Oct 18 2022, 8:51 AM