This is an archive of the discontinued LLVM Phabricator instance.

[lldb-tests] Remove dubious standard library flag
ClosedPublic

Authored by fdeazeve on Oct 18 2022, 6:46 AM.

Details

Summary

The test currently sets USE_LIBSTDCPP = 0, which is curious given the
behavior of and and or in Makefiles (the contents of the variables
are not important). In particular, this causes the tests to not use the
standard libraries appropriately.

To capture the actual intent of the test, we're changing this to
USE_LIBCXX=1.

Diff Detail

Event Timeline

fdeazeve created this revision.Oct 18 2022, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 6:46 AM
fdeazeve requested review of this revision.Oct 18 2022, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2022, 6:46 AM
aprantl accepted this revision.Oct 18 2022, 8:51 AM

This looks obviously correct.

This revision is now accepted and ready to land.Oct 18 2022, 8:51 AM
This revision was automatically updated to reflect the committed changes.
fdeazeve added a comment.EditedOct 18 2022, 11:09 AM

This linux bot failed: https://lab.llvm.org/buildbot/#/builders/68/builds/41314
I've reverted while I give it a try in a linux VM. Interestingly, the standard library flags are not being passed correctly according to the log.