This is an archive of the discontinued LLVM Phabricator instance.

Differential D135889

[lld/mac] Add test for bug fixed in reland 82ca390062d115
ClosedPublic

Authored by thakis on Oct 13 2022, 8:46 AM.

Details

Reviewers
int3
Group Reviewers
Restricted Project
Commits
rG3ab947ede034: [lld/mac] Add test for bug fixed in reland 82ca390062d115

Diff Detail

Event Timeline

thakis created this revision.Oct 13 2022, 8:46 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 13 2022, 8:46 AM
thakis requested review of this revision.Oct 13 2022, 8:46 AM
Harbormaster completed remote builds in B191986: Diff 467500.Oct 13 2022, 8:46 AM
int3 accepted this revision.Oct 13 2022, 8:51 AM
int3 added a subscriber: int3.
int3 added inline comments.
lld/test/MachO/undef-spell-corrector.s
91–93

what was the bug? could we have a comment explaining why this debug section was added to the test?

This revision is now accepted and ready to land.Oct 13 2022, 8:51 AM
thakis mentioned this in D135038: [lld/mac] Port typo correction for undefined symbols from ELF port.Oct 13 2022, 8:53 AM
thakis added a comment.Oct 13 2022, 9:02 AM

Thanks!

lld/test/MachO/undef-spell-corrector.s
91–93

This causes ObjFile::symbols to contain a nullptr. The original patch used dyn_cast for all symbols in ObjFile::symbols. The fix was to use dyn_cast_or_null.

Will add a comment.

This revision was landed with ongoing or failed builds.Oct 13 2022, 9:54 AM
Closed by commit rG3ab947ede034: [lld/mac] Add test for bug fixed in reland 82ca390062d115 (authored by thakis). · Explain Why
This revision was automatically updated to reflect the committed changes.
thakis added a commit: rG3ab947ede034: [lld/mac] Add test for bug fixed in reland 82ca390062d115.
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2022, 9:54 AM

Revision Contents

PathSize
lld/
test/
MachO/
7 lines

Diff 467515

lld/test/MachO/undef-spell-corrector.s

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines
abcde: abcde:
__Z3fooPKi: __Z3fooPKi:
#--- bcde-abcd-abde.s #--- bcde-abcd-abde.s
call bcde call bcde
call abcd call abcd
call abde call abde
# Creates a nullptr entry in ObjFile::symbols, to test we don't crash on that.
.section __DWARF,__debug_aranges,regular,debug
ltmp1:
.byte 0
int3Unsubmitted
Not Done
ReplyInline Actions

what was the bug? could we have a comment explaining why this debug section was added to the test?

int3: what was the bug? could we have a comment explaining why this debug section was added to the…
thakisAuthorUnsubmitted
Done
ReplyInline Actions

This causes ObjFile::symbols to contain a nullptr. The original patch used dyn_cast for all symbols in ObjFile::symbols. The fix was to use dyn_cast_or_null.

Will add a comment.

thakis: This causes ObjFile::symbols to contain a nullptr. The original patch used dyn_cast for all…
.subsections_via_symbols
#--- bbcde-abcdd.s #--- bbcde-abcdd.s
call bbcde call bbcde
call abcdd call abcdd
#--- aabcde-abcdee.s #--- aabcde-abcdee.s
call aabcde call aabcde
call abcdee call abcdee
Show All 14 Lines