This is an archive of the discontinued LLVM Phabricator instance.

dotest.py: Remove useless AttributeError catches
ClosedPublic

Authored by labath on Oct 9 2015, 4:06 AM.

Details

Summary

Test decorators were ignoring AttributeError exceptions. These were introduced three years ago,
and copied to all decorators. They seem to serve no purpose and removing them produces no errors.
Given that they have prevented us from noticing the problem in r249819, I think we should
remove them.

Diff Detail

Event Timeline

labath updated this revision to Diff 36933.Oct 9 2015, 4:06 AM
labath retitled this revision from to dotest.py: Remove useless AttributeError catches.
labath updated this object.
labath added reviewers: zturner, tfiala.
labath added subscribers: lldb-commits, iancottrell.
tfiala accepted this revision.Oct 9 2015, 8:48 AM
tfiala edited edge metadata.

Looks great. Thanks for tracking that down!

This revision is now accepted and ready to land.Oct 9 2015, 8:48 AM
This revision was automatically updated to reflect the committed changes.