[lldb][test] Remove failing ValueCheck on deprecated libcxx entity

[Michael137]

Summary

A recent libcxx change renamed all internal variables starting with
__. As such, std::reverse_iterator::__t was renamed to
std::reverse_iterator::__t_. This breaks the import-std-module
tests with newer libcxx versions. Since this variable is deprecated
in libcxx anyway, this patch simply removes the explicit ValueCheck
on the variable name. We don't lose any interesting test-case here
since the purpose of the test is to see if we can call functions
from the std module.

We can now re-enable the tests on Darwin for all buildbot Clang
compiler variants.

[fdeazeve]

Thanks for looking into this!

lldb/test/API/commands/expression/import-std-module/deque-basic/TestDequeFromStdModule.py

 """
 Test basic std::list functionality.
 """
 
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 
 class TestBasicDeque(TestBase):
 
     @add_test_categories(["libc++"])
-    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @skipIf(compiler=no_match("clang"))
     def test(self):
         self.build()
 
         lldbutil.run_to_source_breakpoint(self,
                                           "// Set break point at this line.",
                                           lldb.SBFileSpec("main.cpp"))
 
         self.runCmd("settings set target.import-std-module true")
 
         deque_type = "std::deque<int>"
         size_type = "size_type"
         value_type = "value_type"
         iterator = "iterator"
         iterator_children = [
             ValueCheck(name="__m_iter_"),
             ValueCheck(name="__ptr_")
         ]
         riterator = "reverse_iterator"
         riterator_children = [
-            ValueCheck(name="__t"),
+            ValueCheck(), # Deprecated __t_ member; no need to check
             ValueCheck(name="current")
         ]
 
         self.expect_expr("a",
                          result_type=deque_type,
                          result_children=[
                              ValueCheck(value='3'),
                              ValueCheck(value='1'),

lldb/test/API/commands/expression/import-std-module/deque-dbg-info-content/TestDbgInfoContentDequeFromStdModule.py

 """
 Test std::deque functionality with a decl from dbg info as content.
 """
 
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 
 class TestDbgInfoContentDeque(TestBase):
 
     @add_test_categories(["libc++"])
-    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @skipIf(compiler=no_match("clang"))
     def test(self):
         self.build()
 
         lldbutil.run_to_source_breakpoint(self,
                                           "// Set break point at this line.",
                                           lldb.SBFileSpec("main.cpp"))
 
         self.runCmd("settings set target.import-std-module true")
 
         deque_type = "std::deque<Foo>"
         size_type = "size_type"
         value_type = "value_type"
 
         iterator_type = "iterator"
         iterator_children = [
             ValueCheck(name="__m_iter_"),
             ValueCheck(name="__ptr_")
         ]
 
         riterator_type = "reverse_iterator"
         riterator_children = [
-            ValueCheck(name="__t"),
+            ValueCheck(), # Deprecated __t_ member; no need to check
             ValueCheck(name="current")
         ]
 
         self.expect_expr("a",
                          result_type=deque_type,
                          result_children=[
                              ValueCheck(children=[ValueCheck(value="3")]),
                              ValueCheck(children=[ValueCheck(value="1")]),

lldb/test/API/commands/expression/import-std-module/vector-dbg-info-content/TestDbgInfoContentVectorFromStdModule.py

 """
 Test basic std::vector functionality but with a declaration from
 the debug info (the Foo struct) as content.
 """
 
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 
 class TestDbgInfoContentVector(TestBase):
 
     @add_test_categories(["libc++"])
-    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @skipIf(compiler=no_match("clang"))
     def test(self):
         self.build()
 
         lldbutil.run_to_source_breakpoint(self,
                                           "// Set break point at this line.",
                                           lldb.SBFileSpec("main.cpp"))
 
         self.runCmd("settings set target.import-std-module true")
 
         vector_type = "std::vector<Foo>"
         size_type = "size_type"
         value_type = "value_type"
         iterator = "iterator"
         # LLDB's formatter provides us with a artificial 'item' member.
         iterator_children = [ValueCheck(name="item")]
         riterator = "reverse_iterator"
         riterator_children = [
-            ValueCheck(name="__t"),
+            ValueCheck(), # Deprecated __t_ member; no need to check
             ValueCheck(name="current")
         ]
 
         self.expect_expr("a",
                          result_type=vector_type,
                          result_children=[
                              ValueCheck(children=[ValueCheck(value="3")]),
                              ValueCheck(children=[ValueCheck(value="1")]),

lldb/test/API/commands/expression/import-std-module/vector/TestVectorFromStdModule.py

 """
 Test basic std::vector functionality.
 """
 
 from lldbsuite.test.decorators import *
 from lldbsuite.test.lldbtest import *
 from lldbsuite.test import lldbutil
 
 
 class TestBasicVector(TestBase):
 
     @add_test_categories(["libc++"])
-    @expectedFailureDarwin # FIXME: May need to force system libcxx here.
     @skipIf(compiler=no_match("clang"))
     def test(self):
         self.build()
 
         lldbutil.run_to_source_breakpoint(self,
                                           "// Set break point at this line.",
                                           lldb.SBFileSpec("main.cpp"))
 
         self.runCmd("settings set target.import-std-module true")
 
         vector_type = "std::vector<int>"
         size_type = "size_type"
         value_type = "value_type"
         iterator = "iterator"
         # LLDB's formatter provides us with a artificial 'item' member.
         iterator_children = [ValueCheck(name="item")]
         riterator = "reverse_iterator"
         riterator_children = [
-            ValueCheck(name="__t"),
+            ValueCheck(), # Deprecated __t_ member; no need to check
             ValueCheck(name="current")
         ]
 
         self.expect_expr("a",
                          result_type=vector_type,
                          result_children=[
                              ValueCheck(value="3"),
                              ValueCheck(value="1"),