This is an archive of the discontinued LLVM Phabricator instance.

Use 4294967296.f instead of 0x1p32f to fix MSVC
ClosedPublic

Authored by angelsl on Oct 3 2015, 10:42 AM.

Details

Reviewers
compnerd

Diff Detail

Event Timeline

angelsl updated this revision to Diff 36439.Oct 3 2015, 10:42 AM
angelsl retitled this revision from to Use 4294967296.f instead of 0x1p32f to fix MSVC.
angelsl updated this object.
angelsl added a reviewer: compnerd.
angelsl added subscribers: compnerd, llvm-commits.
compnerd edited edge metadata.Oct 4 2015, 11:21 AM

I think that this really hurts readability. It is unfortunate that MSVC doesn't support this even as of VS2015. Can you please at least leave the current values as comments? Something like:

su_int high = a / 4294967296.f;         /* a / 0x1p32f; */
angelsl updated this revision to Diff 36481.Oct 4 2015, 11:47 PM
angelsl edited edge metadata.

Corrections made.

compnerd accepted this revision.Oct 5 2015, 7:03 PM
compnerd edited edge metadata.
This revision is now accepted and ready to land.Oct 5 2015, 7:03 PM
compnerd closed this revision.Oct 5 2015, 9:35 PM

SVN r249374.