This is an archive of the discontinued LLVM Phabricator instance.

Differential D134085

[BOLT] Enable llvm-dylib build
ClosedPublic

Authored by Amir on Sep 16 2022, 2:59 PM.

Details

Reviewers
gkistanova
Group Reviewers
Restricted Project
Commits
rZORG153404571240: [BOLT] Enable llvm-dylib build
Summary

Enable testing of a distro build configuration (-DLLVM_LINK_LLVM_DYLIB=ON).
https://github.com/llvm/llvm-project/issues/57551

Diff Detail

Event Timeline

Amir created this revision.Sep 16 2022, 2:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 16 2022, 2:59 PM
Herald added a subscriber: treapster. · View Herald Transcript
Amir requested review of this revision.Sep 16 2022, 2:59 PM
Harbormaster completed remote builds in B187261: Diff 460917.Sep 16 2022, 2:59 PM
Amir planned changes to this revision.Sep 20 2022, 2:53 PM

Sorry, it's not ready yet. Will reopen once BOLT supports this build mode.

Amir requested review of this revision.Sep 27 2022, 12:08 PM

DYLIB build mode is fixed with D134434

gkistanova accepted this revision.Sep 29 2022, 10:01 AM

LGTM.

This revision is now accepted and ready to land.Sep 29 2022, 10:01 AM
Closed by commit rZORG153404571240: [BOLT] Enable llvm-dylib build (authored by Amir). · Explain WhySep 29 2022, 10:52 AM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rZORG153404571240: [BOLT] Enable llvm-dylib build.

Revision Contents

PathSize
buildbot/
osuosl/
master/
config/
19 lines

Diff 463963

buildbot/osuosl/master/config/builders.py

Show First 20 Lines • Show All 2,414 Lines • ▼ Show 20 Lines 'factory' : BOLTBuilder.getBOLTCmakeBuildFactory(
extra_configure_args=[ extra_configure_args=[
"-DLLVM_APPEND_VC_REV=OFF", "-DLLVM_APPEND_VC_REV=OFF",
"-DLLVM_CCACHE_BUILD=ON", "-DLLVM_CCACHE_BUILD=ON",
"-DLLVM_ENABLE_PROJECTS=clang;lld;bolt", "-DLLVM_ENABLE_PROJECTS=clang;lld;bolt",
"-DLLVM_TARGETS_TO_BUILD=X86;AArch64", "-DLLVM_TARGETS_TO_BUILD=X86;AArch64",
], ],
)}, )},
{'name': "bolt-x86_64-ubuntu-dylib",
'tags': ["bolt"],
'collapseRequests': False,
'workernames':["bolt-worker"],
'builddir': "bolt-x86_64-ubuntu-dylib",
'factory' : BOLTBuilder.getBOLTCmakeBuildFactory(
bolttests=False,
extra_configure_args=[
"-DLLVM_APPEND_VC_REV=OFF",
"-DLLVM_CCACHE_BUILD=ON",
"-DLLVM_ENABLE_PROJECTS=bolt",
"-DLLVM_TARGETS_TO_BUILD=X86;AArch64",
"-DLLVM_LINK_LLVM_DYLIB=ON",
"-DLLVM_ENABLE_LLD=ON",
"-DBOLT_CLANG_EXE=/usr/bin/clang",
"-DBOLT_LLD_EXE=/usr/bin/ld.lld",
],
)},
{'name': "bolt-x86_64-ubuntu-shared", {'name': "bolt-x86_64-ubuntu-shared",
'tags': ["bolt"], 'tags': ["bolt"],
'collapseRequests': False, 'collapseRequests': False,
'workernames':["bolt-worker"], 'workernames':["bolt-worker"],
'builddir': "bolt-x86_64-ubuntu-shared", 'builddir': "bolt-x86_64-ubuntu-shared",
'factory' : BOLTBuilder.getBOLTCmakeBuildFactory( 'factory' : BOLTBuilder.getBOLTCmakeBuildFactory(
bolttests=False, bolttests=False,
extra_configure_args=[ extra_configure_args=[
▲ Show 20 Lines • Show All 215 Lines • Show Last 20 Lines