This is an archive of the discontinued LLVM Phabricator instance.

Differential D133811

[test] [fuzzer] ios_run.py incorrectly parses run commands for two fuzzer tests
ClosedPublic

Authored by rsundahl on Sep 13 2022, 3:05 PM.

Details

Reviewers
yln
thetruestblue
wrotki
Commits
rG17dde371e773: [test] [fuzzer] Enable tests for iossim, disable for ios (update2)
Summary

The fuzzer tests cross_over.test and merge-control-file.test are not handled
correctly on ios device testing. On-device testing requires the macros %t, %s,
etc. to be expanded for a different default directory than when testing on host.

rdar://99889376

Diff Detail

Event Timeline

rsundahl created this revision.Sep 13 2022, 3:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 3:05 PM
Herald added a subscriber: Enna1. · View Herald Transcript
rsundahl requested review of this revision.Sep 13 2022, 3:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 13 2022, 3:05 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rsundahl added reviewers: yln, thetruestblue, wrotki.Sep 13 2022, 3:07 PM
Harbormaster completed remote builds in B186467: Diff 459890.Sep 13 2022, 3:49 PM
yln accepted this revision.Sep 13 2022, 3:51 PM

Please fix the one nit I mentioned.

This revision is now accepted and ready to land.Sep 13 2022, 3:51 PM
rsundahl updated this revision to Diff 459910.Sep 13 2022, 4:06 PM

Clean comments.

rsundahl edited the summary of this revision. (Show Details)Sep 13 2022, 4:08 PM
rsundahl updated this revision to Diff 459915.Sep 13 2022, 4:14 PM

Add back some description.

rsundahl updated this revision to Diff 459916.Sep 13 2022, 4:16 PM

Spellingy

This revision was landed with ongoing or failed builds.Sep 13 2022, 4:23 PM
Closed by commit rG17dde371e773: [test] [fuzzer] Enable tests for iossim, disable for ios (update2) (authored by rsundahl). · Explain Why
This revision was automatically updated to reflect the committed changes.
rsundahl added a commit: rG17dde371e773: [test] [fuzzer] Enable tests for iossim, disable for ios (update2).
Harbormaster completed remote builds in B186485: Diff 459916.Sep 13 2022, 4:40 PM

Revision Contents

PathSize
compiler-rt/
test/
fuzzer/
2 lines
3 lines

Diff 459917

compiler-rt/test/fuzzer/cross_over.test

# For IOS, we fail to permute the run lines properly (rdar://99889376)
XFAIL: ios && !iossim
# Tests CrossOverTest. # Tests CrossOverTest.
# We want to make sure that the test can find the input # We want to make sure that the test can find the input
# ABCDEFGHIJ when given two other inputs in the seed corpus: # ABCDEFGHIJ when given two other inputs in the seed corpus:
# ABCDE00000 and # ABCDE00000 and
# ZZZZZFGHIJ # ZZZZZFGHIJ
# #
RUN: %cpp_compiler %S/CrossOverTest.cpp -o %t-CrossOverTest RUN: %cpp_compiler %S/CrossOverTest.cpp -o %t-CrossOverTest
Show All 10 Lines

compiler-rt/test/fuzzer/merge-control-file.test

XFAIL: ios # For IOS, we fail to permute the run lines properly (rdar://99889376)
XFAIL: ios && !iossim
RUN: mkdir -p %t RUN: mkdir -p %t
# Use a ".exe" extension because it is needed on Windows to call system() # Use a ".exe" extension because it is needed on Windows to call system()
# to execute itself again. # to execute itself again.
RUN: %cpp_compiler %S/FullCoverageSetTest.cpp -o %t/T.exe RUN: %cpp_compiler %S/FullCoverageSetTest.cpp -o %t/T.exe
RUN: rm -rf %t/T0 %t/T1 %t/T2 RUN: rm -rf %t/T0 %t/T1 %t/T2
RUN: mkdir -p %t/T0 %t/T1 %t/T2 RUN: mkdir -p %t/T0 %t/T1 %t/T2
RUN: echo F..... > %t/T0/1 RUN: echo F..... > %t/T0/1
▲ Show 20 Lines • Show All 42 Lines • Show Last 20 Lines