This is an archive of the discontinued LLVM Phabricator instance.

Differential D133254

[libc++][locale] Removes an transitive include.
ClosedPublic

Authored by Mordante on Sep 3 2022, 5:57 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rGab7b776cf957: [libc++][locale] Removes an transitive include.
Summary

Removes <cstdarg> transitive include from <locale> in C++23.

Diff Detail

Event Timeline

Mordante created this revision.Sep 3 2022, 5:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2022, 5:57 AM
Mordante requested review of this revision.Sep 3 2022, 5:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 3 2022, 5:57 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B184951: Diff 457786.Sep 3 2022, 7:29 AM
ldionne accepted this revision.Sep 6 2022, 11:03 AM
ldionne added a subscriber: ldionne.

The commit message should probably be something like Removes <cstdarg> transitive include from <locale> in C++23

This revision is now accepted and ready to land.Sep 6 2022, 11:03 AM
Mordante edited the summary of this revision. (Show Details)Sep 7 2022, 9:47 AM
Closed by commit rGab7b776cf957: [libc++][locale] Removes an transitive include. (authored by Mordante). · Explain WhySep 7 2022, 9:54 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rGab7b776cf957: [libc++][locale] Removes an transitive include..

Revision Contents

PathSize
libcxx/
docs/
2 lines
include/
2 lines
test/
libcxx/
transitive_includes/
cxx2b/
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line

Diff 458489

libcxx/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
Deprecations and Removals Deprecations and Removals
------------------------- -------------------------
- Several incidental transitive includes have been removed from libc++. Those - Several incidental transitive includes have been removed from libc++. Those
includes are removed based on the language version used. Incidental transitive includes are removed based on the language version used. Incidental transitive
inclusions of the following headers have been removed: inclusions of the following headers have been removed:
- C++20: ``chrono`` - C++20: ``chrono``
- C++2b: ``algorithm``, ``array``, ``atomic``, ``bit``, ``chrono``, - C++2b: ``algorithm``, ``array``, ``atomic``, ``bit``, ``chrono``,
``climits``, ``cmath``, ``compare``, ``concepts``, ``cstdlib``, ``climits``, ``cmath``, ``compare``, ``concepts``, ``cstdarg``, ``cstdlib``,
``cstring``, ``ctime``, ``exception``, ``functional``, ``cstring``, ``ctime``, ``exception``, ``functional``,
``initializer_list``, ``iosfwd``, ``iterator``, ``memory``, ``new``, ``initializer_list``, ``iosfwd``, ``iterator``, ``memory``, ``new``,
``optional``, ``ratio``, ``stdexcept``, ``tuple``, ``typeinfo``, ``optional``, ``ratio``, ``stdexcept``, ``tuple``, ``typeinfo``,
``unordered_map``, ``utility``, ``variant``, ``vector``. ``unordered_map``, ``utility``, ``variant``, ``vector``.
Users can also remove all incidental transitive includes by defining Users can also remove all incidental transitive includes by defining
``_LIBCPP_REMOVE_TRANSITIVE_INCLUDES`` regardless of the language version ``_LIBCPP_REMOVE_TRANSITIVE_INCLUDES`` regardless of the language version
in use. Note that in the future, libc++ reserves the right to remove in use. Note that in the future, libc++ reserves the right to remove
Show All 22 Lines

libcxx/include/locale

Show First 20 Lines • Show All 196 Lines • ▼ Show 20 Lines
#include <__config> #include <__config>
#include <__debug> #include <__debug>
#include <__iterator/access.h> #include <__iterator/access.h>
#include <__iterator/back_insert_iterator.h> #include <__iterator/back_insert_iterator.h>
#include <__iterator/istreambuf_iterator.h> #include <__iterator/istreambuf_iterator.h>
#include <__iterator/ostreambuf_iterator.h> #include <__iterator/ostreambuf_iterator.h>
#include <__locale> #include <__locale>
#include <__memory/unique_ptr.h> #include <__memory/unique_ptr.h>
#include <cstdarg> // TODO: Remove this include
#include <cstdio> #include <cstdio>
#include <cstdlib> #include <cstdlib>
#include <ctime> #include <ctime>
#include <ios> #include <ios>
#include <limits> #include <limits>
#include <new> #include <new>
#include <streambuf> #include <streambuf>
#include <version> #include <version>
▲ Show 20 Lines • Show All 4,135 Lines • ▼ Show 20 Lines
_LIBCPP_SUPPRESS_DEPRECATED_POP _LIBCPP_SUPPRESS_DEPRECATED_POP
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
_LIBCPP_POP_MACROS _LIBCPP_POP_MACROS
#if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20 #if !defined(_LIBCPP_REMOVE_TRANSITIVE_INCLUDES) && _LIBCPP_STD_VER <= 20
# include <cstdarg>
# include <iterator> # include <iterator>
#endif #endif
#endif // _LIBCPP_LOCALE #endif // _LIBCPP_LOCALE

libcxx/test/libcxx/transitive_includes/cxx2b/expected.ccomplex

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
complex complex
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 21 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.complex

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 21 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.ctgmath

atomic atomic
bitset bitset
ccomplex ccomplex
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
complex complex
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 21 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.filesystem

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 21 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.format

array array
atomic atomic
bit bit
cctype cctype
cerrno cerrno
charconv charconv
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 19 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.fstream

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 22 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.iomanip

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 20 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.iostream

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 20 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.istream

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 19 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.locale

atomic atomic
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 17 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.ostream

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 18 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.sstream

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 20 Lines

libcxx/test/libcxx/transitive_includes/cxx2b/expected.strstream

atomic atomic
bitset bitset
cctype cctype
cerrno cerrno
climits climits
cmath cmath
compare compare
concepts concepts
cstdarg
cstddef cstddef
cstdint cstdint
cstdio cstdio
cstdlib cstdlib
cstring cstring
ctime ctime
cwchar cwchar
cwctype cwctype
Show All 20 Lines