[SingleSource] Add Regression C tests for Large Divide.

[FreddyYe]

Summary

This is regression test for https://github.com/llvm/llvm-project/issues/44994

[FreddyYe]

Extend the test and verify if pre-merge test is working.

[mgehre-amd]

SingleSource/Regression/C/issue44994-1.c

43

I'm not sure I understand why we need to use a union and manually care about endianess.
I'm thinking that writing

unsigned _BitInt(256) a = 6;
unsigned _BitInt(256) b = 3;
unsigned _BitInt(256) q = a / b;
unsigned _BitInt(256) expected = 2;
if(q != expected)
  return 1;

should work fine on little and big endian machines.

Another thing to look out for is that those tests are not fully optimized to constants, and then there is no div left for the backend.
I guess we can either use -O0, or add some dependency on argc or similar.

[FreddyYe]

SingleSource/Regression/C/issue44994-1.c

43

I'm not sure I understand why we need to use a union and manually care about endianess.

It's only because I don't have a better way to initialize _BitInt(256) (e.g. 0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF). Do you know a better way?

Another thing to look out for is that those tests are not fully optimized to constants.

According to the main_dump I generated with O2, I think the ExpandLargeDiv Pass is working. And I can find %div = udiv i256 %0, %1 in IR generated under O2.

[mgehre-amd]

SingleSource/Regression/C/issue44994-1.c

43

Maybe using the literal suffixes would work, see clang/test/Lexer/bitint-constants.c?

SingleSource/Regression/C/Makefile

PROGRAMS_TO_SKIP += \
   badidx \
   bigstack \
   callargs \
   casts \
   compare \
   ConstructorDestructorAttributes \
   DuffsDevice \
   globalrefs \
+  issue44994-1 \
+  issue44994-2 \
+  issue44994-3 \
+  issue44994-4 \
   matrixTranspose \
   pointer_arithmetic \
   PR10189 \
   PR1386 \
   PR491 \
   PR640 \
   sumarray \
   sumarray2d \
   sumarraymalloc \
   test_indvars \
   testtrace
 endif
 
 include $(LEVEL)/SingleSource/Makefile.singlesrc
 

SingleSource/Regression/C/issue44994-1.c

+#include <stdio.h>
+
+union usBitIntUion {
+   unsigned int i;
+   unsigned long long a[4];
+   unsigned _BitInt(256) b;
+};
+
+union usBitIntUion A,B,R,E;
+
+void make_BitIntA(unsigned long long a3, unsigned long long a2,
+                  unsigned long long a1, unsigned long long a0) {
+  A.a[0] = a0;
+  A.a[1] = a1;
+  A.a[2] = a2;
+  A.a[3] = a3;
+}
+
+void make_BitIntB(unsigned long long a3, unsigned long long a2,
+                  unsigned long long a1, unsigned long long a0) {
+  B.a[0] = a0;
+  B.a[1] = a1;
+  B.a[2] = a2;
+  B.a[3] = a3;
+}
+
+void make_BitIntE(unsigned long long a3, unsigned long long a2,
+                  unsigned long long a1, unsigned long long a0) {
+  E.a[0] = a0;
+  E.a[1] = a1;
+  E.a[2] = a2;
+  E.a[3] = a3;
+}
+
+int test()
+{
+    R.b = A.b / B.b;
+    return R.b != E.b;
+}
+
+int main()
+{
+    make_BitIntA(0, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0, 0, 0, 2);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 2);
+    if (test())
+        return 1;
+    make_BitIntA(0x8000000000000000uLL, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0x8000000000000000uLL, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0x8000000000000000uLL, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 2);
+    make_BitIntE(0x4000000000000000uLL, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0xFFFFFFFFFFFFFFFFuLL, 0xFFFFFFFFFFFFFFFFuLL,
+                 0xFFFFFFFFFFFFFFFFuLL, 0xFFFFFFFFFFFFFFFFuLL);
+    make_BitIntB(0, 0, 0, 2);
+    make_BitIntE(0x7FFFFFFFFFFFFFFFuLL, 0xFFFFFFFFFFFFFFFFuLL,
+                 0xFFFFFFFFFFFFFFFFuLL, 0xFFFFFFFFFFFFFFFFuLL);
+    if (test())
+        return 1;
+    return 0;
+}

SingleSource/Regression/C/issue44994-1.reference_output

+exit 0

SingleSource/Regression/C/issue44994-2.c

+#include <stdio.h>
+
+union sBitIntUion {
+   int i;
+   long long a[4];
+   _BitInt(256) b;
+};
+
+union sBitIntUion A, B, R, E;
+
+void make_BitIntA(long long a3, long long a2,
+                  long long a1, long long a0) {
+  A.a[0] = a0;
+  A.a[1] = a1;
+  A.a[2] = a2;
+  A.a[3] = a3;
+}
+
+void make_BitIntB(long long a3, long long a2,
+                  long long a1, long long a0) {
+  B.a[0] = a0;
+  B.a[1] = a1;
+  B.a[2] = a2;
+  B.a[3] = a3;
+}
+
+void make_BitIntE(long long a3, long long a2,
+                  long long a1, long long a0) {
+  E.a[0] = a0;
+  E.a[1] = a1;
+  E.a[2] = a2;
+  E.a[3] = a3;
+}
+
+int test()
+{
+    R.b = A.b / B.b;
+    return R.b != E.b;
+}
+
+int main()
+{
+    make_BitIntA(0, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0, 0, 0, 0);
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL); // -1
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        return 1;
+
+    make_BitIntA(0, 0, 0, 2);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 2);
+    if (test())
+        return 1;
+    make_BitIntA(0, 0, 0, 2);
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL); // -1
+    make_BitIntE(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFELL); // -2
+    if (test())
+        return 1;
+    make_BitIntA(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFELL); // -2
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFELL); // -2
+    if (test())
+        return 1;
+    make_BitIntA(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFELL); // -2
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL); // -1
+    make_BitIntE(0, 0, 0, 2);
+    if (test())
+        return 1;
+
+    make_BitIntA(0x8000000000000000LL, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0x8000000000000000LL, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0x8000000000000000LL, 0, 0, 0);
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL); // -1
+    make_BitIntA(0x8000000000000000LL, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0x8000000000000000LL, 0, 0, 0);
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFELL); // -2
+    make_BitIntE(0x4000000000000000LL, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0x8000000000000000LL, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 2);
+    make_BitIntE(0xC000000000000000LL, 0, 0, 0);
+    if (test())
+        return 1;
+    return 2; // this is a intent test.
+}

SingleSource/Regression/C/issue44994-2.reference_output

+exit 0

SingleSource/Regression/C/issue44994-3.c

+#include <stdio.h>
+
+union usBitIntUion {
+   unsigned int i;
+   unsigned long long a[4];
+   unsigned _BitInt(256) b;
+};
+
+union usBitIntUion A,B,R,E;
+
+void make_BitIntA(unsigned long long a3, unsigned long long a2,
+                  unsigned long long a1, unsigned long long a0) {
+  A.a[0] = a0;
+  A.a[1] = a1;
+  A.a[2] = a2;
+  A.a[3] = a3;
+}
+
+void make_BitIntB(unsigned long long a3, unsigned long long a2,
+                  unsigned long long a1, unsigned long long a0) {
+  B.a[0] = a0;
+  B.a[1] = a1;
+  B.a[2] = a2;
+  B.a[3] = a3;
+}
+
+void make_BitIntE(unsigned long long a3, unsigned long long a2,
+                  unsigned long long a1, unsigned long long a0) {
+  E.a[0] = a0;
+  E.a[1] = a1;
+  E.a[2] = a2;
+  E.a[3] = a3;
+}
+
+int test()
+{
+    R.b = A.b % B.b;
+    return R.b != E.b;
+}
+
+int main()
+{
+    make_BitIntA(0, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0, 0, 0, 2);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0, 0, 0, 19);
+    make_BitIntB(0, 0, 0, 5);
+    make_BitIntE(0, 0, 0, 4);
+    if (test())
+        return 1;
+    make_BitIntA(0x8000000000000000uLL, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 8);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        return 1;
+    make_BitIntA(0x8000000000000000uLL, 0, 0, 3);
+    make_BitIntB(0, 0, 0, 8);
+    make_BitIntE(0, 0, 0, 3);
+    if (test())
+        return 1;
+    return 0;
+}

SingleSource/Regression/C/issue44994-3.reference_output

+exit 0

SingleSource/Regression/C/issue44994-4.c

+#include <stdio.h>
+
+union sBitIntUion {
+   int i;
+   long long a[4];
+   _BitInt(256) b;
+};
+
+union sBitIntUion A, B, R, E;
+
+void make_BitIntA(long long a3, long long a2,
+                  long long a1, long long a0) {
+  A.a[0] = a0;
+  A.a[1] = a1;
+  A.a[2] = a2;
+  A.a[3] = a3;
+}
+
+void make_BitIntB(long long a3, long long a2,
+                  long long a1, long long a0) {
+  B.a[0] = a0;
+  B.a[1] = a1;
+  B.a[2] = a2;
+  B.a[3] = a3;
+}
+
+void make_BitIntE(long long a3, long long a2,
+                  long long a1, long long a0) {
+  E.a[0] = a0;
+  E.a[1] = a1;
+  E.a[2] = a2;
+  E.a[3] = a3;
+}
+
+int test()
+{
+    R.b = A.b % B.b;
+    return R.b != E.b;
+}
+
+int main()
+{
+    make_BitIntA(0, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        printf("0\n");//return 1;
+    make_BitIntA(0, 0, 0, 0);
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL); // -1
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        printf("1\n");//return 1;
+
+    make_BitIntA(0, 0, 0, 2);
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        printf("2\n");//return 1;
+    make_BitIntA(0, 0, 0, 2);
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL); // -1
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        printf("3\n");//return 1;
+    make_BitIntA(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFELL); // -2
+    make_BitIntB(0, 0, 0, 1);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        printf("4\n");//return 1;
+    make_BitIntA(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFELL); // -2
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL); // -1
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        printf("5\n");//return 1;
+
+    make_BitIntA(0, 0, 0, 7);
+    make_BitIntB(0, 0, 0, 5);
+    make_BitIntE(0, 0, 0, 2);
+    if (test())
+        printf("6\n");//return 1;
+    make_BitIntA(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFF9LL); // -7
+    make_BitIntB(0, 0, 0, 5);
+    make_BitIntE(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFELL); // -2
+    if (test())
+        printf("7\n");//return 1;
+    make_BitIntA(0, 0, 0, 19);
+    make_BitIntB(0, 0, 0, 5);
+    make_BitIntE(0, 0, 0, 4);
+    if (test())
+        printf("8\n");//return 1;
+    make_BitIntA(0, 0, 0, 19);
+    make_BitIntB(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFBLL); // -5
+    make_BitIntE(0, 0, 0, 4);
+    if (test())
+        printf("9\n");//return 1;
+    make_BitIntA(0x8000000000000000LL, 0, 0, 0);
+    make_BitIntB(0, 0, 0, 8);
+    make_BitIntE(0, 0, 0, 0);
+    if (test())
+        printf("10\n");//return 1;
+    make_BitIntA(0x8000000000000000LL, 0, 0, 7);
+    make_BitIntB(0, 0, 0, 8);
+    make_BitIntE(0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL,
+                 0xFFFFFFFFFFFFFFFFLL, 0xFFFFFFFFFFFFFFFFLL); // -1
+    if (test())
+        printf("11\n");//return 1;
+    return 0;
+}

SingleSource/Regression/C/issue44994-4.reference_output

+exit 0