This is an archive of the discontinued LLVM Phabricator instance.

Differential D132596

[lldb][nfc] Remove unused makefile test variables
ClosedPublic

Authored by fdeazeve on Aug 24 2022, 12:59 PM.

Details

Reviewers
JDevlieghere
Commits
rG14d5ae2038b5: [lldb][nfc] Remove unused makefile test variables
Summary

The variables LLDB_USING_LIBSTDCPP and LLDB_USING_LIBSTDCPP are no
longer used anywhere.

Diff Detail

Event Timeline

fdeazeve created this revision.Aug 24 2022, 12:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 12:59 PM
fdeazeve requested review of this revision.Aug 24 2022, 12:59 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2022, 12:59 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
fdeazeve added a reviewer: JDevlieghere.Aug 24 2022, 1:00 PM
Harbormaster completed remote builds in B183199: Diff 455336.Aug 24 2022, 1:02 PM
JDevlieghere accepted this revision.Aug 24 2022, 6:08 PM

LGTM, I meant to remove those in a previous patch. Thanks for following up on that.

This revision is now accepted and ready to land.Aug 24 2022, 6:08 PM
fdeazeve updated this revision to Diff 455523.Aug 25 2022, 3:39 AM

Fixed typo in commit message

This revision was landed with ongoing or failed builds.Aug 25 2022, 3:40 AM
Closed by commit rG14d5ae2038b5: [lldb][nfc] Remove unused makefile test variables (authored by fdeazeve). · Explain Why
This revision was automatically updated to reflect the committed changes.
fdeazeve added a commit: rG14d5ae2038b5: [lldb][nfc] Remove unused makefile test variables.
Harbormaster completed remote builds in B183328: Diff 455523.Aug 25 2022, 3:42 AM

Revision Contents

PathSize
lldb/
packages/
Python/
lldbsuite/
test/
make/
3 lines

Diff 455523

lldb/packages/Python/lldbsuite/test/make/Makefile.rules

Show First 20 Lines • Show All 375 Lines • ▼ Show 20 Lines
endif endif
#---------------------------------------------------------------------- #----------------------------------------------------------------------
# C++ standard library options # C++ standard library options
#---------------------------------------------------------------------- #----------------------------------------------------------------------
ifeq (1,$(USE_LIBSTDCPP)) ifeq (1,$(USE_LIBSTDCPP))
# Clang requires an extra flag: -stdlib=libstdc++ # Clang requires an extra flag: -stdlib=libstdc++
ifneq (,$(findstring clang,$(CC))) ifneq (,$(findstring clang,$(CC)))
CXXFLAGS += -stdlib=libstdc++ -DLLDB_USING_LIBSTDCPP CXXFLAGS += -stdlib=libstdc++
LDFLAGS += -stdlib=libstdc++ LDFLAGS += -stdlib=libstdc++
endif endif
endif endif
ifeq (1,$(USE_LIBCPP)) ifeq (1,$(USE_LIBCPP))
CXXFLAGS += -DLLDB_USING_LIBCPP
ifneq ($(and $(LIBCPP_INCLUDE_DIR), $(LIBCPP_LIBRARY_DIR)),) ifneq ($(and $(LIBCPP_INCLUDE_DIR), $(LIBCPP_LIBRARY_DIR)),)
CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(LIBCPP_INCLUDE_DIR) CXXFLAGS += -nostdlib++ -nostdinc++ -cxx-isystem $(LIBCPP_INCLUDE_DIR)
LDFLAGS += -L$(LLVM_LIBS_DIR) -Wl,-rpath,$(LIBCPP_LIBRARY_DIR) -lc++ LDFLAGS += -L$(LLVM_LIBS_DIR) -Wl,-rpath,$(LIBCPP_LIBRARY_DIR) -lc++
else else
ifeq "$(OS)" "Android" ifeq "$(OS)" "Android"
# Nothing to do, this is already handled in # Nothing to do, this is already handled in
# Android.rules. # Android.rules.
else else
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines