This is an archive of the discontinued LLVM Phabricator instance.

Differential D132521

[AST] Reuse PrintingPolicy from ASTContext
AbandonedPublic

Authored by JOE1994 on Aug 23 2022, 6:41 PM.

Details

Reviewers
None
Summary

No need to create a duplicate PrintingPolicy when we can reuse the
PrintingPolicy from ASTContext.

Diff Detail

Unit TestsFailed

TimeTest
90 msx64 debian > Clang.AST::ast-print-bool.c
170 msx64 debian > Clang.SemaTemplate::temp_arg_string_printing.cpp

Event Timeline

JOE1994 created this revision.Aug 23 2022, 6:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2022, 6:41 PM
JOE1994 requested review of this revision.Aug 23 2022, 6:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2022, 6:41 PM
Harbormaster completed remote builds in B182990: Diff 455038.Aug 23 2022, 8:38 PM
JOE1994 updated this revision to Diff 455157.Aug 24 2022, 4:13 AM

Add missed out 'const'

Harbormaster completed remote builds in B183077: Diff 455157.Aug 24 2022, 5:10 AM
JOE1994 abandoned this revision.Aug 24 2022, 2:09 PM

Revision Contents

PathSize
clang/
lib/
Frontend/
2 lines

Diff 455157

clang/lib/Frontend/ASTConsumers.cpp

//===--- ASTConsumers.cpp - ASTConsumer implementations -------------------===// //===--- ASTConsumers.cpp - ASTConsumer implementations -------------------===//
Lint: Lint
Inline Actions

clang-format not found in user’s local PATH; not linting file.

Lint: Lint: clang-format not found in user’s local PATH; not linting file.
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
▲ Show 20 Lines • Show All 78 Lines • ▼ Show 20 Lines void print(Decl *D) {
if (DC == DC->getPrimaryContext()) if (DC == DC->getPrimaryContext())
DC->dumpLookups(Out, OutputKind != None, OutputKind == DumpFull); DC->dumpLookups(Out, OutputKind != None, OutputKind == DumpFull);
else else
Out << "Lookup map is in primary DeclContext " Out << "Lookup map is in primary DeclContext "
<< DC->getPrimaryContext() << "\n"; << DC->getPrimaryContext() << "\n";
} else } else
Out << "Not a DeclContext\n"; Out << "Not a DeclContext\n";
} else if (OutputKind == Print) { } else if (OutputKind == Print) {
PrintingPolicy Policy(D->getASTContext().getLangOpts()); const PrintingPolicy &Policy = D->getASTContext().getPrintingPolicy();
D->print(Out, Policy, /*Indentation=*/0, /*PrintInstantiation=*/true); D->print(Out, Policy, /*Indentation=*/0, /*PrintInstantiation=*/true);
} else if (OutputKind != None) { } else if (OutputKind != None) {
D->dump(Out, OutputKind == DumpFull, OutputFormat); D->dump(Out, OutputKind == DumpFull, OutputFormat);
} }
if (DumpDeclTypes) { if (DumpDeclTypes) {
Decl *InnerD = D; Decl *InnerD = D;
if (auto *TD = dyn_cast<TemplateDecl>(D)) if (auto *TD = dyn_cast<TemplateDecl>(D))
▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines