I noticed this problem when staring at some debug output. I added an assert which catches it with existing tests and a test case.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
The patch looks fine but really should have a testcase, maybe creating a .mir test is feasible here?
Comment Actions
Yes, '-stop-after' makes it straight-forward to create a test case. Added. Thanks for the pointer.
Comment Actions
LGTM
test/CodeGen/ARM/thumb1-ldst-opt.ll | ||
---|---|---|
1 ↗ | (On Diff #36100) | I slightly prefer target triple = "thumbv6m-none-none" instead of passing -mtriple to llc (mainly because it safes typing for people manually invoking llc on a testcase). |
Comment Actions
Committed including changing from -mtriple ... to target triple = ...
Thanks for the review.