This is an archive of the discontinued LLVM Phabricator instance.

Add ability to compile for different Go subarch values.
ClosedPublic

Authored by randall77 on Aug 15 2022, 3:51 PM.

Diff Detail

Event Timeline

randall77 created this revision.Aug 15 2022, 3:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2022, 3:51 PM
Herald added a subscriber: Enna1. · View Herald Transcript
randall77 requested review of this revision.Aug 15 2022, 3:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 15 2022, 3:51 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dvyukov accepted this revision.Aug 16 2022, 12:52 AM
dvyukov added a reviewer: thanm.
This revision is now accepted and ready to land.Aug 16 2022, 12:52 AM

Is there something else I need to do to get this submitted?

thanm added a comment.Aug 23 2022, 4:51 PM

I can submit it for you if that would be helpful.

This revision was automatically updated to reflect the committed changes.
dyung added a subscriber: dyung.Aug 28 2022, 1:12 PM
dyung added inline comments.
compiler-rt/lib/tsan/go/buildgo.sh
62

In our private linux buildbot, I noticed a (warning?) message from this line:

compiler-rt/lib/tsan/rtl/../go/buildgo.sh: 62: [: ==: unexpected operator

From some quick googling, it seems that == may be bash specific and the sh equivalent is just =.