[libc++][test] fix C4267 warning in bitset.members\to_ulong.pass.cpp

[fsb4000]

Summary

warning C4267: 'initializing': conversion from 'size_t' to 'unsigned long', possible loss of data

[philnik]

What does it warn on when you don't explicitly cast if to unsigned long?

[fsb4000]

My minimal repro: https://gcc.godbolt.org/z/vxefsMT7v

[philnik]

I mean why are you casting it to unsigned long? AFAICT std::bitset() should take an unsigned long long, so it shouldn't be a narrowing conversion when calling it with std::size_t.

[fsb4000]

Thanks. Yes, you are right. It fixes the warning too.

libcxx/test/std/utilities/template.bitset/bitset.members/to_ulong.pass.cpp

std::size_t tests[] = {
         std::min<std::size_t>(1, max),
         std::min<std::size_t>(2, max),
         std::min<std::size_t>(3, max),
         std::min(max, max-3),
         std::min(max, max-2),
         std::min(max, max-1),
         max
     };
-    for (unsigned long j : tests) {
-         std::bitset<N> v(j);
+    for (std::size_t j : tests) {
         assert(j == v.to_ulong());
     }
 
     { // test values bigger than can fit into the bitset
         const unsigned long val = 0x5AFFFFA5UL;
         const bool canFit = N < sizeof(unsigned long) * CHAR_BIT;
         const unsigned long mask = canFit ? (1UL << (canFit ? N : 0)) - 1 : (unsigned long)(-1); // avoid compiler warnings
         std::bitset<N> v(val);