This is an archive of the discontinued LLVM Phabricator instance.

[libc++][test] Restore several variant tests
AbandonedPublic

Authored by fsb4000 on Aug 14 2022, 12:40 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Summary

They were removed in https://reviews.llvm.org/D120684
I think it was made by mistake...
The code compiles just fine, even with -Weverything: https://gcc.godbolt.org/z/oKjvb8oPx

Diff Detail

Event Timeline

fsb4000 created this revision.Aug 14 2022, 12:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 14 2022, 12:40 AM
fsb4000 requested review of this revision.Aug 14 2022, 12:40 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2022, 12:40 AM
fsb4000 abandoned this revision.Aug 14 2022, 1:19 AM

Oh, it seems it fails with gcc and libc++ and -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER
I use clang-cl and Windows locally so I can't test it locally but now I think the tests were removed intentionally.
Ok.