This is an archive of the discontinued LLVM Phabricator instance.

workflows/version-check: Fix check for release candidates
ClosedPublic

Authored by tstellar on Aug 10 2022, 10:28 PM.

Diff Detail

Event Timeline

tstellar created this revision.Aug 10 2022, 10:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 10:28 PM
tstellar requested review of this revision.Aug 10 2022, 10:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 10 2022, 10:28 PM
thieta accepted this revision.Aug 11 2022, 12:18 AM

LGTM with one small question.

.github/workflows/version-check.py
29

Is it unthinkable that we would ever do a rc for a non .0.0 version? It's fine for now but we could just match [0-9] or \d here as well I think.

This revision is now accepted and ready to land.Aug 11 2022, 12:18 AM
tstellar updated this revision to Diff 452104.Aug 12 2022, 1:38 AM

Handle release candidate tags for any release.

tstellar marked an inline comment as done.Aug 12 2022, 1:38 AM
thieta accepted this revision.Aug 12 2022, 2:01 AM

Very nice! LGTM

This revision was landed with ongoing or failed builds.Aug 19 2022, 9:51 PM
This revision was automatically updated to reflect the committed changes.