This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Remove --env PATH from the static clangcl config
ClosedPublic

Authored by mstorsjo on Aug 9 2022, 3:39 AM.

Details

Summary

The PATH is set in order to be able to find the tested DLL at runtime.
When linking statically, it's not necessary to set the PATH.

Setting PATH in the executor has the downside that it clears the
existing path (it's not prepended/appended to it), which means
that the executed tools can't find other tools - which sets the
executor-has-no-bash flag.

By removing the unnecessary setting of PATH, we have a properly
working bash even when wrapped by the executor, which gets rid
of the executor-has-no-bash flag in this test configuration, which
makes 9 more testcases be executed.

Diff Detail

Event Timeline

mstorsjo created this revision.Aug 9 2022, 3:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 3:39 AM
mstorsjo requested review of this revision.Aug 9 2022, 3:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2022, 3:39 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Aug 18 2022, 1:30 PM
This revision is now accepted and ready to land.Aug 18 2022, 1:30 PM