This is an archive of the discontinued LLVM Phabricator instance.

Differential D131288

[Sanitizer][Darwin] Support OS versions before DRIVERKIT
ClosedPublic

Authored by keith on Aug 5 2022, 1:26 PM.

Details

Reviewers
yln
Commits
rG9ec4ddd224f4: [Sanitizer][Darwin] Support OS versions before DRIVERKIT
Summary

Fixes https://github.com/llvm/llvm-project/issues/56960

Diff Detail

Event Timeline

keith created this revision.Aug 5 2022, 1:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 1:26 PM
Herald added a subscriber: Enna1. · View Herald Transcript
keith requested review of this revision.Aug 5 2022, 1:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 5 2022, 1:26 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
keith added a reviewer: yln.Aug 5 2022, 1:27 PM
yln accepted this revision.Aug 5 2022, 1:44 PM

LGTM, thanks! :)

I am running macOS 10.12.6

👻

This revision is now accepted and ready to land.Aug 5 2022, 1:44 PM
Harbormaster completed remote builds in B179579: Diff 450375.Aug 5 2022, 1:49 PM
Closed by commit rG9ec4ddd224f4: [Sanitizer][Darwin] Support OS versions before DRIVERKIT (authored by keith). · Explain WhyAug 5 2022, 3:39 PM
This revision was automatically updated to reflect the committed changes.
keith added a commit: rG9ec4ddd224f4: [Sanitizer][Darwin] Support OS versions before DRIVERKIT.
keith added a comment.Aug 5 2022, 7:45 PM

😂

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
2 lines

Diff 450437

compiler-rt/lib/sanitizer_common/sanitizer_platform.h

Show First 20 Lines • Show All 84 Lines • ▼ Show 20 Lines
# else # else
# define SANITIZER_TVOS 0 # define SANITIZER_TVOS 0
# endif # endif
# if TARGET_OS_SIMULATOR # if TARGET_OS_SIMULATOR
# define SANITIZER_IOSSIM 1 # define SANITIZER_IOSSIM 1
# else # else
# define SANITIZER_IOSSIM 0 # define SANITIZER_IOSSIM 0
# endif # endif
# if TARGET_OS_DRIVERKIT # if defined(TARGET_OS_DRIVERKIT) && TARGET_OS_DRIVERKIT
# define SANITIZER_DRIVERKIT 1 # define SANITIZER_DRIVERKIT 1
# else # else
# define SANITIZER_DRIVERKIT 0 # define SANITIZER_DRIVERKIT 0
# endif # endif
#else #else
# define SANITIZER_APPLE 0 # define SANITIZER_APPLE 0
# define SANITIZER_OSX 0 # define SANITIZER_OSX 0
# define SANITIZER_IOS 0 # define SANITIZER_IOS 0
▲ Show 20 Lines • Show All 348 Lines • Show Last 20 Lines