Page MenuHomePhabricator

[darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios
ClosedPublic

Authored by beanz on Sep 23 2015, 11:37 AM.

Details

Summary

Xcode 7 doesn't support targeting iOS5 and earlier. Instead of just dropping cc_kext_ios5, I've repurposed it to cc_kext_ios, and I'm pulling the iOS architectures out of cc_kext. Putting OS X and iOS slices inside the same archive was just odd.

There is a cooresponding clang change coming too.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 35536.Sep 23 2015, 11:37 AM
beanz retitled this revision from to [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios.
beanz updated this object.
beanz added reviewers: bogner, bob.wilson.
beanz added a subscriber: llvm-commits.
bob.wilson added inline comments.Sep 23 2015, 12:50 PM
make/platform/clang_darwin.mk
102 ↗(On Diff #35536)

This comment needs to be updated.

163 ↗(On Diff #35536)

Changing the minimum deployment version from 1 to 6 seems like it ought to be a separate patch.

beanz added inline comments.Sep 23 2015, 1:10 PM
make/platform/clang_darwin.mk
102 ↗(On Diff #35536)

Will revise.

163 ↗(On Diff #35536)

This actually isn't a functional change. The version 1.0 was only used by the cc_kext_ios5 targets that I'm removing, so I just renamed the IOS6 variable to IOS since the IOS variable became unused.

beanz updated this revision to Diff 35545.Sep 23 2015, 1:12 PM
  • Updated comment based on feedback from Bob
bob.wilson added inline comments.Sep 23 2015, 1:29 PM
make/platform/clang_darwin.mk
161 ↗(On Diff #35545)

Check again. IOS_DEPLOYMENT_ARGS is used for everything except the cc_kext and arm64 versions.

beanz updated this revision to Diff 35549.Sep 23 2015, 1:36 PM

Adding back in -mios-version-min=1.0

bob.wilson accepted this revision.Sep 23 2015, 3:07 PM
bob.wilson edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Sep 23 2015, 3:07 PM