This is an archive of the discontinued LLVM Phabricator instance.

[llvm][macos] Fix usage of std::shared_mutex on old macOS SDK versions
ClosedPublic

Authored by thieta on Aug 3 2022, 3:07 AM.

Details

Summary

When setting CMAKE_CXX_STANDARD to 17 and targeting a macOS version
under 10.12 the ifdefs would try to use std::shared_mutex because
the of the C++ standard. This should also check the targeted SDK.

See discussion in: https://reviews.llvm.org/D130689

Diff Detail

Event Timeline

thieta created this revision.Aug 3 2022, 3:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2022, 3:07 AM
thieta requested review of this revision.Aug 3 2022, 3:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 3 2022, 3:07 AM
nikic accepted this revision.Aug 3 2022, 3:40 AM

LG

This revision is now accepted and ready to land.Aug 3 2022, 3:40 AM