This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer_common] Return nullptr on ASan allocator commitment error.
Needs ReviewPublic

Authored by jschwartzentruber on Jul 29 2022, 8:28 AM.

Details

Reviewers
timurrrr
kcc
Summary

This happens on Windows when an allocation exceeds available page file
size. It should be treated the same as out-of-memory.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2022, 8:28 AM
Herald added a subscriber: Enna1. · View Herald Transcript
jschwartzentruber requested review of this revision.Jul 29 2022, 8:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 29 2022, 8:28 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

This was reported as https://bugzilla.mozilla.org/show_bug.cgi?id=1769798 and the patch has been verified to fix that bug (against clang 14.0.5).