Page MenuHomePhabricator

[docs] Update DominatorTree docs to clarify expectations around unreachable blocks
ClosedPublic

Authored by reames on Sep 22 2015, 4:34 PM.

Details

Summary

Note: I'm am not trying to describe what "should be"; I'm only describing what is true today.

The text has been discussed offline with DannyB, but I wanted to a) give him a final chance to comment and b) make sure others were okay with the proposed wording.

This came out of my recent question to llvm-dev titled: When can the dominator tree not contain a node for a basic block?

Diff Detail

Repository
rL LLVM

Event Timeline

reames updated this revision to Diff 35438.Sep 22 2015, 4:34 PM
reames retitled this revision from to [docs] Update DominatorTree docs to clarify expectations around unreachable blocks.
reames updated this object.
reames added a subscriber: llvm-commits.

lgtm aside from a typo

include/llvm/Support/GenericDomTree.h
375 ↗(On Diff #35438)

typo: s/an/a/

This revision was automatically updated to reflect the committed changes.
dberlin edited edge metadata.Sep 23 2015, 11:48 AM

It's closed, but just FYI, it looked fine to me, so i never hit respond.