Page MenuHomePhabricator

[LoopUnswitch] Require DominatorTree info.
ClosedPublic

Authored by mzolotukhin on Sep 21 2015, 5:01 PM.

Details

Summary

We should either require the DT info to be available, or check if it's
available in every place we use DT (and we already miss such check in
one place, which causes failures in some cases). As other loop passes
preserve DT and it's usually available, it makes sense to just require
it here.

Diff Detail

Repository
rL LLVM

Event Timeline

mzolotukhin retitled this revision from to [LoopUnswitch] Require DominatorTree info..
mzolotukhin updated this object.
mzolotukhin added reviewers: chandlerc, hfinkel.
mzolotukhin added a subscriber: llvm-commits.
chandlerc accepted this revision.Sep 21 2015, 5:03 PM
chandlerc edited edge metadata.

LGTM

Mention in the commit log that this is really annoying to test for? =/ Somewhat sad to not have a test but I have no better ideas.

This revision is now accepted and ready to land.Sep 21 2015, 5:03 PM
This revision was automatically updated to reflect the committed changes.

Thanks! Committed with the corresponding comment.

Michael