Conversion from '__int64' to 'long', possible loss of data

[fsb4000]

Summary

llvm-project\libcxx\test\std\time\time.hms\time.hms.members\seconds.pass.cpp(38): note: see reference to function template instantiation 'long check_seconds<std::chrono::seconds>(Duration)' being compiled

with
[
    Duration=std::chrono::seconds
]

llvm-project\libcxx\test\std\time\time.hms\time.hms.members\seconds.pass.cpp(31): warning C4244: 'return': conversion from '_Rep' to 'long', possible loss of data

with
[
    _Rep=__int64
]

[Mordante]

Thanks for making the test compatible with MSVC STL. LGTM, one question.

libcxx/test/std/time/time.hms/time.hms.members/seconds.pass.cpp

26

How do you feel about using int64_t instead?

[fsb4000]

Sure, int64_t is fine too.
I will create diff now.

[fsb4000]

use int64_t instead of long long

[Mordante]

Thanks, I'll land it on your behalf when the CI is green.

[Mordante]

I've landed this one too, so now all 3 of your test fixes for MSVC STL have landed.
Thanks for the improvements!

[fsb4000]

Thank you too!

libcxx/test/std/time/time.hms/time.hms.members/seconds.pass.cpp

 // class hh_mm_ss
 //
 // constexpr chrono::seconds seconds() const noexcept;
 //
 // See the table in hours.pass.cpp for correspondence between the magic values used below
 
 #include <chrono>
 #include <cassert>
+#include <cstdint>
 #include <ratio>
 #include <utility>
 
 #include "test_macros.h"
 
 template <typename Duration>
-constexpr long check_seconds(Duration d)
+constexpr int64_t check_seconds(Duration d)
 {
     using HMS = std::chrono::hh_mm_ss<Duration>;
     ASSERT_SAME_TYPE(std::chrono::seconds, decltype(std::declval<HMS>().seconds()));
     ASSERT_NOEXCEPT(                                std::declval<HMS>().seconds());
     return HMS(d).seconds().count();
 }
 
 int main(int, char**)

libcxx/test/std/time/time.hms/time.hms.members/subseconds.pass.cpp

 // class hh_mm_ss
 //
 // constexpr precision subseconds() const noexcept;
 //
 // See the table in hours.pass.cpp for correspondence between the magic values used below
 
 #include <chrono>
 #include <cassert>
+#include <cstdint>
 #include <ratio>
 #include <utility>
 
 #include "test_macros.h"
 
 template <typename Duration>
-constexpr long check_subseconds(Duration d)
+constexpr int64_t check_subseconds(Duration d)
 {
     using HMS = std::chrono::hh_mm_ss<Duration>;
     ASSERT_SAME_TYPE(typename HMS::precision, decltype(std::declval<HMS>().subseconds()));
     ASSERT_NOEXCEPT(                                   std::declval<HMS>().subseconds());
     return HMS(d).subseconds().count();
 }
 
 int main(int, char**)