Page MenuHomePhabricator

AMDGPU: Handle i64->v2i32 loads/stores in PreprocessISelDAG
ClosedPublic

Authored by arsenm on Sep 18 2015, 4:20 PM.

Details

Reviewers
tstellarAMD
Summary

This fixes a select error when the i64 source was also
bitcasted to v2i32 in the original source.

Instead of awkwardly trying to select the modified source value and
the store, replace before isel begins.

Uses a worklist to avoid possible problems from mutating the DAG,
although it seems to work OK without it.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 35150.Sep 18 2015, 4:20 PM
arsenm retitled this revision from to AMDGPU: Handle i64->v2i32 loads/stores in PreprocessISelDAG.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Sep 25 2015, 9:54 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Sep 25 2015, 9:54 AM
arsenm closed this revision.Sep 25 2015, 10:28 AM

r248589