This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Improves pragma system_header test.
ClosedPublic

Authored by Mordante on Jul 3 2022, 9:43 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG8cb5c82ad23b: [libc++] Improves pragma system_header test.
Summary

The number of spaces between # and pragma can differ due to
different indention levels in the preprocessor directives. Therefore
allow any number of spaces.

The test used to put an exclamation mark in its diagnostic. This adds
little benefit and only makes it harder to copy the offending filename.
As drive-by this exclamation mark has been removed.

Diff Detail

Event Timeline

Mordante created this revision.Jul 3 2022, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 9:43 AM
Mordante requested review of this revision.Jul 3 2022, 9:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2022, 9:43 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Jul 6 2022, 9:36 AM
This revision is now accepted and ready to land.Jul 6 2022, 9:36 AM
This revision was landed with ongoing or failed builds.Jul 6 2022, 11:54 AM
This revision was automatically updated to reflect the committed changes.