Page MenuHomePhabricator

[OpenCL] Add new types for OpenCL 2.0.
ClosedPublic

Authored by bader on Sep 14 2015, 11:36 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

bader updated this revision to Diff 34709.Sep 14 2015, 11:36 AM
bader retitled this revision from to [OpenCL] Add new types for OpenCL 2.0..
bader updated this object.
bader added a reviewer: pekka.jaaskelainen.
bader added a subscriber: cfe-commits.
pekka.jaaskelainen edited edge metadata.

The patch seems straightforward enough. BTW does someone know if anyone has worked on the 'pipe' qualifier?

lib/Serialization/ASTCommon.cpp
70 ↗(On Diff #34709)

A nitpick, but why deviate from the style where each case has been stuffed to a single line?

This revision is now accepted and ready to land.Sep 14 2015, 10:47 PM
bader added a comment.Sep 15 2015, 2:17 AM

The patch seems straightforward enough. BTW does someone know if anyone has worked on the 'pipe' qualifier?

I'm currently supporting Intel's implementation of 'pipe' qualifier and I'd like to contribute this implementation to the community if there is any interest.

lib/Serialization/ASTCommon.cpp
70 ↗(On Diff #34709)

My guess it's effect of clang-format. Original patch sent by Pedro matched the style, but violated 80-character limit, so he was asked to run clang-format over the patch. Do you want me to run clang-format on surrounding code to unify the style?

We are interested in the pipe.

I don't think it makes sense to increase the patch size by running the stylifier. Perhaps in an additional patch after this?

This revision was automatically updated to reflect the committed changes.