Link NetBSD with execinfo (CMAKE build)

[krytarowski]

Summary

FreeBSD and NetBSD share the same library execinfo.

[sas]

cmake/LLDBDependencies.cmake

152

Looks like you have a typo. MAKE_SYSTEM_NAME vs. CMAKE_SYSTEM_NAME.

[krytarowski]

typo

[brucem]

cmake/LLDBDependencies.cmake

152

This should really be replaced with a cmake-style check for where to find backtrace.

cmake 3.0 added a built-in package to handle this, but I think we still support an older cmake:

http://www.cmake.org/cmake/help/v3.0/module/FindBacktrace.html

Since this is how the cmake build finds this, we don't need to worry about having other build systems here and we can do this in the correct way for cmake.

[sas]

@brucem, not sure exactly what way forward you are suggesting. LLDB build system supports cmake 2.8.12 and up, so we can't use FindBacktrace unless we bump that to 3.0. Are we recommending we do that?

[krytarowski]

In D12750#244435, @sas wrote:

@brucem, not sure exactly what way forward you are suggesting. LLDB build system supports cmake 2.8.12 and up, so we can't use FindBacktrace unless we bump that to 3.0. Are we recommending we do that?

Can we do this later, after merging this change at it is? For now I won't be able to test the new approach.

[sas]

I'm fine with this patch the way it is. Unless @brucem refuses, I'll submit it. Improving cmake checks can be dealt with later on.

[krytarowski]

In D12750#244435, @sas wrote:

@brucem, not sure exactly what way forward you are suggesting. LLDB build system supports cmake 2.8.12 and up, so we can't use FindBacktrace unless we bump that to 3.0. Are we recommending we do that?

Can we do this later, after merging this change at it is? For now I won't be able to test the new approach.

In D12750#248348, @sas wrote:

I'm fine with this patch the way it is. Unless @brucem refuses, I'll submit it. Improving cmake checks can be dealt with later on.

We have got CMake 2.8 set as the minimal requirement.

cmake_minimum_required(VERSION 2.8)

I'm willing to push NetBSD bits first and then refactor for all platforms.

Are you OK with it @brucem?

[brucem]

We can do that other part later ... we don't have to require newer cmake to do it, just provide our own file that does something similar until we update to newer cmake.

[sas]

Committed as r248007.

cmake/LLDBDependencies.cmake

 if (NOT CMAKE_SYSTEM_NAME MATCHES "Windows" AND NOT __ANDROID_NDK__)
   if (NOT LLDB_DISABLE_LIBEDIT)
     list(APPEND LLDB_SYSTEM_LIBS edit)
   endif()
   if (NOT LLDB_DISABLE_CURSES)
     list(APPEND LLDB_SYSTEM_LIBS panel ncurses)
   endif()
 endif()
-# On FreeBSD backtrace() is provided by libexecinfo, not libc.
-if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD")
+# On FreeBSD/NetBSD backtrace() is provided by libexecinfo, not libc.
+if (CMAKE_SYSTEM_NAME MATCHES "FreeBSD" OR MAKE_SYSTEM_NAME MATCHES "NetBSD")
   list(APPEND LLDB_SYSTEM_LIBS execinfo)
 endif()
 
 if (NOT LLDB_DISABLE_PYTHON AND NOT LLVM_BUILD_STATIC)
   list(APPEND LLDB_SYSTEM_LIBS ${PYTHON_LIBRARIES})
 endif()
 
 list(APPEND LLDB_SYSTEM_LIBS ${system_libs})