This is an archive of the discontinued LLVM Phabricator instance.

Differential D127151

[libcxx] [doc] Add a release note for distributors about MinGW builds and dllimport
ClosedPublic

Authored by mstorsjo on Jun 6 2022, 1:58 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG8ab2c384b8ad: [libcxx] [doc] Add a release note for distributors about MinGW builds and…
Summary

This allows distributors to simplify how libc++ is built in MinGW
configurations.

Diff Detail

Event Timeline

mstorsjo created this revision.Jun 6 2022, 1:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 1:58 PM
mstorsjo requested review of this revision.Jun 6 2022, 1:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 1:58 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B168147: Diff 434602.Jun 6 2022, 4:16 PM
ldionne accepted this revision.Jun 9 2022, 8:51 AM
ldionne added inline comments.
libcxx/docs/ReleaseNotes.rst
186
This revision is now accepted and ready to land.Jun 9 2022, 8:51 AM
Closed by commit rG8ab2c384b8ad: [libcxx] [doc] Add a release note for distributors about MinGW builds and… (authored by mstorsjo). · Explain WhyJun 9 2022, 12:32 PM
This revision was automatically updated to reflect the committed changes.
mstorsjo added a commit: rG8ab2c384b8ad: [libcxx] [doc] Add a release note for distributors about MinGW builds and….

Revision Contents

PathSize
libcxx/
docs/
5 lines

Diff 435645

libcxx/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 177 Lines • ▼ Show 20 Lines- The legacy testing configuration is now deprecated and will be removed in the next release. For
most users, this should not have any impact. However, if you are testing libc++, libc++abi or most users, this should not have any impact. However, if you are testing libc++, libc++abi or
libunwind in a configuration or on a platform that used to be supported by the legacy testing libunwind in a configuration or on a platform that used to be supported by the legacy testing
configuration and isn't supported by one of the configurations in ``libcxx/test/configs``, configuration and isn't supported by one of the configurations in ``libcxx/test/configs``,
``libcxxabi/test/configs`` or ``libunwind/test/configs``, please move to one of those ``libcxxabi/test/configs`` or ``libunwind/test/configs``, please move to one of those
configurations or define your own. configurations or define your own.
- The ``LIBCXX_ENABLE_DEBUG_MODE_SUPPORT`` CMake configuration is not supported anymore. If you - The ``LIBCXX_ENABLE_DEBUG_MODE_SUPPORT`` CMake configuration is not supported anymore. If you
were disabling support for the debug mode with that flag, please use ``LIBCXX_ENABLE_BACKWARDS_COMPATIBILITY_DEBUG_MODE_SYMBOLS=OFF`` were disabling support for the debug mode with that flag, please use ``LIBCXX_ENABLE_BACKWARDS_COMPATIBILITY_DEBUG_MODE_SYMBOLS=OFF``
instead. instead.
ldionneUnsubmitted
Not Done
ReplyInline Actions
that the same set of installed headers works for both DLL and static linkage.
- This means that distributors finally can build both library versions with one
+ This means that distributors finally can build both library versions with a
single CMake invocation.
ldionne:
- MinGW DLL builds of libc++ no longer use dllimport in their headers, which
means that the same set of installed headers works for both DLL and static
linkage. This means that distributors finally can build both library
versions with a single CMake invocation.