This is an archive of the discontinued LLVM Phabricator instance.

Fix log message warning in SBThread.
ClosedPublic

Authored by brucem on Sep 8 2015, 5:02 PM.

Reviewers

clayborg
jingham

Commits

Summary

The format string was not set up correctly as it was missing the %.
This resulted in a warning (correctly) that the data arguments were
not all used.

brucem retitled this revision from to Fix log message warning in SBThread..

brucem updated this object.

brucem added a subscriber: lldb-commits.

clayborg edited edge metadata.

This revision is now accepted and ready to land.Sep 8 2015, 5:21 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

source/

API/

2 lines

Show First 20 Lines • Show All 880 Lines • ▼ Show 20 Lines	SBThread::StepOutOfFrame (lldb::SBFrame &sb_frame)

if (exe_ctx.HasThreadScope())		if (exe_ctx.HasThreadScope())
{		{
bool abort_other_plans = false;		bool abort_other_plans = false;
bool stop_other_threads = false;		bool stop_other_threads = false;
Thread *thread = exe_ctx.GetThreadPtr();		Thread *thread = exe_ctx.GetThreadPtr();
if (sb_frame.GetThread().GetThreadID() != thread->GetID())		if (sb_frame.GetThread().GetThreadID() != thread->GetID())
{		{
log->Printf("SBThread(%p)::StepOutOfFrame passed a frame from another thread (0x" PRIx64 " vrs. 0x" PRIx64 ", returning.",		log->Printf("SBThread(%p)::StepOutOfFrame passed a frame from another thread (0x%" PRIx64 " vrs. 0x%" PRIx64 ", returning.",
static_cast<void*>(exe_ctx.GetThreadPtr()),		static_cast<void*>(exe_ctx.GetThreadPtr()),
sb_frame.GetThread().GetThreadID(),		sb_frame.GetThread().GetThreadID(),
thread->GetID());		thread->GetID());
}		}

ThreadPlanSP new_plan_sp(thread->QueueThreadPlanForStepOut (abort_other_plans,		ThreadPlanSP new_plan_sp(thread->QueueThreadPlanForStepOut (abort_other_plans,
NULL,		NULL,
false,		false,
▲ Show 20 Lines • Show All 718 Lines • Show Last 20 Lines