This is an archive of the discontinued LLVM Phabricator instance.

Differential D126229

[Sanitizer][Darwin] Add explanation for Apple platform macros
ClosedPublic

Authored by yln on May 23 2022, 11:34 AM.

Details

Reviewers
thetruestblue
rsundahl
wrotki
Commits
rG1962389979be: [Sanitizer][Darwin] Add explanation for Apple platform macros

Diff Detail

Event Timeline

yln created this revision.May 23 2022, 11:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 11:34 AM
yln requested review of this revision.May 23 2022, 11:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 23 2022, 11:34 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B165885: Diff 431438.May 23 2022, 11:54 AM
rsundahl added a comment.May 23 2022, 11:55 AM

LGTM (I'd like to see SANTIZER_OSX become SANITIZER_MACOS at some point for consistency.)

rsundahl accepted this revision.May 23 2022, 11:55 AM
This revision is now accepted and ready to land.May 23 2022, 11:55 AM
Closed by commit rG1962389979be: [Sanitizer][Darwin] Add explanation for Apple platform macros (authored by yln). · Explain WhyMay 23 2022, 11:59 AM
This revision was automatically updated to reflect the committed changes.
yln added a commit: rG1962389979be: [Sanitizer][Darwin] Add explanation for Apple platform macros.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
9 lines

Diff 431446

compiler-rt/lib/sanitizer_common/sanitizer_platform.h

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines
#endif #endif
#if defined(__sun__) && defined(__svr4__) #if defined(__sun__) && defined(__svr4__)
# define SANITIZER_SOLARIS 1 # define SANITIZER_SOLARIS 1
#else #else
# define SANITIZER_SOLARIS 0 # define SANITIZER_SOLARIS 0
#endif #endif
// - SANITIZER_APPLE: all Apple code
// - TARGET_OS_OSX: macOS
// - SANITIZER_IOS: devices (iOS and iOS-like)
// - SANITIZER_WATCHOS
// - SANITIZER_TVOS
// - SANITIZER_IOSSIM: simulators (iOS and iOS-like)
// - SANITIZER_DRIVERKIT
#if defined(__APPLE__) #if defined(__APPLE__)
# define SANITIZER_APPLE 1 # define SANITIZER_APPLE 1
// SANITIZER_MAC will be deprecated/removed in the future // SANITIZER_MAC will be deprecated/removed in the future
# define SANITIZER_MAC SANITIZER_APPLE # define SANITIZER_MAC SANITIZER_APPLE
# include <TargetConditionals.h> # include <TargetConditionals.h>
# if TARGET_OS_OSX # if TARGET_OS_OSX
# define SANITIZER_OSX 1 # define SANITIZER_OSX 1
# else # else
Show All 22 Lines
# if TARGET_OS_DRIVERKIT # if TARGET_OS_DRIVERKIT
# define SANITIZER_DRIVERKIT 1 # define SANITIZER_DRIVERKIT 1
# else # else
# define SANITIZER_DRIVERKIT 0 # define SANITIZER_DRIVERKIT 0
# endif # endif
#else #else
# define SANITIZER_APPLE 0 # define SANITIZER_APPLE 0
# define SANITIZER_MAC SANITIZER_APPLE # define SANITIZER_MAC SANITIZER_APPLE
# define SANITIZER_OSX 0
# define SANITIZER_IOS 0 # define SANITIZER_IOS 0
# define SANITIZER_WATCHOS 0 # define SANITIZER_WATCHOS 0
# define SANITIZER_TVOS 0 # define SANITIZER_TVOS 0
# define SANITIZER_IOSSIM 0 # define SANITIZER_IOSSIM 0
# define SANITIZER_OSX 0
# define SANITIZER_DRIVERKIT 0 # define SANITIZER_DRIVERKIT 0
#endif #endif
#if defined(_WIN32) #if defined(_WIN32)
# define SANITIZER_WINDOWS 1 # define SANITIZER_WINDOWS 1
#else #else
# define SANITIZER_WINDOWS 0 # define SANITIZER_WINDOWS 0
#endif #endif
▲ Show 20 Lines • Show All 330 Lines • Show Last 20 Lines