This is an archive of the discontinued LLVM Phabricator instance.

Paths

[gn build] Use -I= instead of explicitly handling sysroot
AcceptedPublic

Authored by thakis on May 23 2022, 9:29 AM.

Reviewers

aeubanks

Summary

See e.g. de87e5f87565b787 for some more information on -I=.

No intended behavior change.

	Time	Test
	60,080 ms	x64 debian > MLIR.Examples/standalone::test.toy
	60,060 ms	x64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp

thakis requested review of this revision.May 23 2022, 9:29 AM

what about setting $sysroot to $sdk_path in llvm/utils/gn/build/BUILD.gn?

This revision is now accepted and ready to land.May 23 2022, 9:34 AM

Path

Size

llvm/

utils/

gn/

build/

libs/

xml/

13 lines

	import("//llvm/utils/gn/build/libs/xml/enable.gni")			import("//llvm/utils/gn/build/libs/xml/enable.gni")
	import("//llvm/utils/gn/build/mac_sdk.gni")
	import("//llvm/utils/gn/build/sysroot.gni")

	config("xml_config") {			config("xml_config") {
	visibility = [ ":xml" ]			visibility = [ ":xml" ]
	libs = [ "xml2" ]			libs = [ "xml2" ]
	if (host_os == "mac") {
	include_dirs = [ "$mac_sdk_path/usr/include/libxml2" ]			# The leading '=' means that this absolute path is relative to the sysroot,
	} else {			# if one is being used.
	include_dirs = [ "$sysroot/usr/include/libxml2" ]			# (Can't use `include_dirs` because GN doesn't know about leading `=`
	}			# and treats `=/...` as a relative path.)
				cflags = [ "-I=/usr/include/libxml2" ]
	}			}

	group("xml") {			group("xml") {
	if (llvm_enable_libxml2) {			if (llvm_enable_libxml2) {
	public_configs = [ ":xml_config" ]			public_configs = [ ":xml_config" ]
	}			}
	}			}