This is an archive of the discontinued LLVM Phabricator instance.

[lldb/test] Fix PExpect.launch issue when disabling color support
ClosedPublic

Authored by mib on May 19 2022, 2:46 PM.

Details

Summary

This patch should fix a bug in PExpect.launch that happened when color
support is not enabled.

In that case, we need to add the --no-use-colors flag to lldb's launch
argument list. However, previously, each character to the string was
appended separately to the args list. This patch solves that by adding
the whole string to the list.

This should fix the TestIOHandlerResize failure on GreenDragon.

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>

Diff Detail

Event Timeline

mib created this revision.May 19 2022, 2:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 19 2022, 2:46 PM
mib requested review of this revision.May 19 2022, 2:46 PM
JDevlieghere accepted this revision.May 19 2022, 2:46 PM
This revision is now accepted and ready to land.May 19 2022, 2:46 PM
This revision was landed with ongoing or failed builds.May 19 2022, 2:47 PM
This revision was automatically updated to reflect the committed changes.