This is an archive of the discontinued LLVM Phabricator instance.

Differential D125702

Refine comments.
AbandonedPublic

Authored by laramiel on May 16 2022, 9:59 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project

Diff Detail

Event Timeline

laramiel created this revision.May 16 2022, 9:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 9:59 AM
laramiel requested review of this revision.May 16 2022, 9:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 9:59 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B164674: Diff 429753.May 16 2022, 10:00 AM
laramiel abandoned this revision.May 16 2022, 10:00 AM
Mordante mentioned this in D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..May 16 2022, 11:14 AM

Revision Contents

PathSize
libcxx/
include/
__random/
21 lines

Diff 429753

libcxx/include/__random/seed_seq.h

Show First 20 Lines • Show All 103 Lines • ▼ Show 20 Lines if (__first != __last)
{ {
result_type __r = 1664525 * _Tp(__first[0] ^ __first[__p] result_type __r = 1664525 * _Tp(__first[0] ^ __first[__p]
^ __first[__n - 1]); ^ __first[__n - 1]);
__first[__p] += __r; __first[__p] += __r;
__r += __s; __r += __s;
__first[__q] += __r; __first[__q] += __r;
__first[0] = __r; __first[0] = __r;
} }
// initialize {(__k + x) % __n} indexing terms
size_t __kmodn = 0; // __k % __n size_t __kmodn = 0; // __k % __n
size_t __k1modn = __n - 1; // (__k - 1) % __n
size_t __kpmodn = __p % __n; // (__k + __p) % __n size_t __kpmodn = __p % __n; // (__k + __p) % __n
size_t __kqmodn = __q % __n; // (__k + __q) % __n size_t __kqmodn = __q % __n; // (__k + __q) % __n
size_t __km1modn = __n - 1; // (__k-1) % __n
for (size_t __k = 1; __k <= __s; ++__k) for (size_t __k = 1; __k <= __s; ++__k)
{ {
if (++__kmodn == __n) if (++__kmodn == __n)
__kmodn = 0; __kmodn = 0;
if (++__km1modn == __n) if (++__k1modn == __n)
__km1modn = 0; __k1modn = 0;
if (++__kpmodn == __n) if (++__kpmodn == __n)
__kpmodn = 0; __kpmodn = 0;
if (++__kqmodn == __n) if (++__kqmodn == __n)
__kqmodn = 0; __kqmodn = 0;
result_type __r = 1664525 * _Tp(__first[__kmodn] ^ __first[__kpmodn] ^ __first[__km1modn]); result_type __r = 1664525 * _Tp(__first[__kmodn] ^ __first[__kpmodn] ^ __first[__k1modn]);
__first[__kpmodn] += __r; __first[__kpmodn] += __r;
__r += __kmodn + __v_[__k - 1]; __r += __kmodn + __v_[__k - 1];
__first[__kqmodn] += __r; __first[__kqmodn] += __r;
__first[__kmodn] = __r; __first[__kmodn] = __r;
} }
for (size_t __k = __s + 1; __k < __m; ++__k) for (size_t __k = __s + 1; __k < __m; ++__k)
{ {
if (++__kmodn == __n) if (++__kmodn == __n)
__kmodn = 0; __kmodn = 0;
if (++__km1modn == __n) if (++__k1modn == __n)
__km1modn = 0; __k1modn = 0;
if (++__kpmodn == __n) if (++__kpmodn == __n)
__kpmodn = 0; __kpmodn = 0;
if (++__kqmodn == __n) if (++__kqmodn == __n)
__kqmodn = 0; __kqmodn = 0;
result_type __r = 1664525 * _Tp(__first[__kmodn] ^ __first[__kpmodn] ^ __first[__km1modn]); result_type __r = 1664525 * _Tp(__first[__kmodn] ^ __first[__kpmodn] ^ __first[__k1modn]);
__first[__kpmodn] += __r; __first[__kpmodn] += __r;
__r += __kmodn; __r += __kmodn;
__first[__kqmodn] += __r; __first[__kqmodn] += __r;
__first[__kmodn] = __r; __first[__kmodn] = __r;
} }
for (size_t __k = __m; __k < __m + __n; ++__k) for (size_t __k = __m; __k < __m + __n; ++__k)
{ {
if (++__kmodn == __n) if (++__kmodn == __n)
__kmodn = 0; __kmodn = 0;
if (++__km1modn == __n) if (++__k1modn == __n)
__km1modn = 0; __k1modn = 0;
if (++__kpmodn == __n) if (++__kpmodn == __n)
__kpmodn = 0; __kpmodn = 0;
if (++__kqmodn == __n) if (++__kqmodn == __n)
__kqmodn = 0; __kqmodn = 0;
result_type __r = 1566083941 * _Tp(__first[__kmodn] + __first[__kpmodn] + __first[__km1modn]); result_type __r = 1566083941 * _Tp(__first[__kmodn] + __first[__kpmodn] + __first[__k1modn]);
__first[__kpmodn] ^= __r; __first[__kpmodn] ^= __r;
__r -= __kmodn; __r -= __kmodn;
__first[__kqmodn] ^= __r; __first[__kqmodn] ^= __r;
__first[__kmodn] = __r; __first[__kmodn] = __r;
} }
} }
} }
_LIBCPP_END_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
_LIBCPP_POP_MACROS _LIBCPP_POP_MACROS
#endif // _LIBCPP___RANDOM_SEED_SEQ_H #endif // _LIBCPP___RANDOM_SEED_SEQ_H