Page MenuHomePhabricator

laramiel (Laramie Leavitt)
User

Projects

User does not belong to any projects.

User Details

User Since
May 10 2022, 10:58 AM (7 w, 2 d)

Recent Activity

May 20 2022

laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Updating D125329: Rebase

May 20 2022, 10:34 AM · Restricted Project, Restricted Project
laramiel added a comment to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

I would prefer help landing a patch; lar@google.com (Laramie Leavitt)

May 20 2022, 10:30 AM · Restricted Project, Restricted Project
laramiel added inline comments to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..
May 20 2022, 10:27 AM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Updating D125329: Update comment on loop.

May 20 2022, 10:26 AM · Restricted Project, Restricted Project
laramiel added a comment to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

The abseil code is internal, and we opted to upstream the main optimization rather than push another std:: compatible type, so I don't have a public reference there.

May 20 2022, 10:20 AM · Restricted Project, Restricted Project

May 17 2022

laramiel added a comment to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

It's all back and the buildbot has completed a green build.

May 17 2022, 9:27 AM · Restricted Project, Restricted Project

May 16 2022

laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Try arc diff origin/main, which seems to work after the rebase.

May 16 2022, 11:15 AM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Rebase. Does this fix it.

May 16 2022, 11:06 AM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Sort benchmark consts

May 16 2022, 10:05 AM · Restricted Project, Restricted Project
laramiel updated the summary of D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..
May 16 2022, 10:02 AM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Adjust comments & rename km1modn to k1modn.

May 16 2022, 10:01 AM · Restricted Project, Restricted Project
laramiel abandoned D125702: Refine comments..
May 16 2022, 10:00 AM · Restricted Project, Restricted Project
laramiel requested review of D125702: Refine comments..
May 16 2022, 9:59 AM · Restricted Project, Restricted Project
laramiel added inline comments to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..
May 16 2022, 9:50 AM · Restricted Project, Restricted Project

May 13 2022

laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Updating D125329: Rebase

May 13 2022, 11:14 AM · Restricted Project, Restricted Project

May 12 2022

laramiel added a comment to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

What next? The AIX 32-bit build fails with an unrelated error, all the rest pass.

May 12 2022, 11:53 PM · Restricted Project, Restricted Project

May 10 2022

laramiel abandoned D125346: Update file comment.
May 10 2022, 4:38 PM · Restricted Project, Restricted Project
laramiel added inline comments to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..
May 10 2022, 4:21 PM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Updating D125329: Replace modulus operations in std::seed_seq::generate with conditional checks.

May 10 2022, 4:12 PM · Restricted Project, Restricted Project
laramiel requested review of D125346: Update file comment.
May 10 2022, 4:08 PM · Restricted Project, Restricted Project
laramiel added a comment to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Ok, I managed to run the benchmarks with the before and after on both my x86 workstation and my mac M1 laptop. For the M1, the new code is about the same, but the new code is dramatically faster on x86.

May 10 2022, 4:01 PM · Restricted Project, Restricted Project
laramiel added inline comments to D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..
May 10 2022, 12:59 PM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Updating D125329: Replace modulus operations in std::seed_seq::generate with conditional checks.

May 10 2022, 12:58 PM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Updating D125329: Replace modulus operations in std::seed_seq::generate with conditional checks.

May 10 2022, 12:21 PM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Updating D125329: Replace modulus operations in std::seed_seq::generate with conditional checks.

May 10 2022, 12:13 PM · Restricted Project, Restricted Project
laramiel updated the diff for D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks..

Add benchmark file.

May 10 2022, 12:07 PM · Restricted Project, Restricted Project
laramiel published D125329: [libc++] Replace modulus operations in std::seed_seq::generate with conditional checks. for review.
May 10 2022, 11:38 AM · Restricted Project, Restricted Project