This is an archive of the discontinued LLVM Phabricator instance.

Differential D125630

[libc++][doc] Clarify wording on the status page.
ClosedPublic

Authored by Mordante on May 15 2022, 6:29 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG773c6e4358da: [libc++][doc] Clarify wording on the status page.

Diff Detail

Event Timeline

Mordante created this revision.May 15 2022, 6:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2022, 6:29 AM
Mordante requested review of this revision.May 15 2022, 6:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2022, 6:29 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.May 15 2022, 6:49 AM

LGTM % nit.

libcxx/docs/Status/Cxx20.rst
45
This revision is now accepted and ready to land.May 15 2022, 6:49 AM
Mordante updated this revision to Diff 429536.May 15 2022, 7:39 AM

Address review comments.

Mordante marked an inline comment as done.May 15 2022, 7:39 AM

Thanks for the review!

Harbormaster completed remote builds in B164514: Diff 429536.May 15 2022, 9:22 AM
Closed by commit rG773c6e4358da: [libc++][doc] Clarify wording on the status page. (authored by Mordante). · Explain WhyMay 29 2022, 6:33 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG773c6e4358da: [libc++][doc] Clarify wording on the status page..

Revision Contents

PathSize
libcxx/
docs/
Status/
4 lines

Diff 432784

libcxx/docs/Status/Cxx20.rst

Show All 35 Lines
.. csv-table:: .. csv-table::
:file: Cxx20Papers.csv :file: Cxx20Papers.csv
:header-rows: 1 :header-rows: 1
:widths: auto :widths: auto
.. note:: .. note::
.. [#note-P0600] P0600: The missing bits in P0600 are in |sect|\ [mem.res.class] and |sect|\ [mem.poly.allocator.class]. .. [#note-P0600] P0600: The missing bits in P0600 are in |sect|\ [mem.res.class] and |sect|\ [mem.poly.allocator.class].
.. [#note-P0645] P0645: The paper is implemented but still marked as an incomplete feature. Not yet implemented LWG-issues will cause API and ABI breakage. .. [#note-P0645] P0645: The paper is implemented but still marked as an incomplete feature
(the feature-test macro is not set and the libary is only available when built with ``LIBCXX_ENABLE_INCOMPLETE_FEATURES``).
philnikUnsubmitted
Done
ReplyInline Actions
.. [#note-P0645] P0645: The paper is implemented but still marked as an incomplete feature
- (the feature-test macro is not set and the libary is only available when built with ``LIBCXX_ENABLE_INCOMPLETE_FEATURES`` set).
+ (the feature-test macro is not set and the libary is only available when built with ``LIBCXX_ENABLE_INCOMPLETE_FEATURES``).
Not yet implemented LWG-issues will cause API and ABI breakage.
philnik:
Not yet implemented LWG-issues will cause API and ABI breakage.
.. [#note-P0966] P0966: It was previously erroneously marked as complete in version 8.0. See `bug 45368 <https://llvm.org/PR45368>`__. .. [#note-P0966] P0966: It was previously erroneously marked as complete in version 8.0. See `bug 45368 <https://llvm.org/PR45368>`__.
.. [#note-P0619] P0619: Only sections D.8, D.9, D.10 and D.13 are implemented. Sections D.4, D.7, D.11, D.12, and D.14 remain undone. .. [#note-P0619] P0619: Only sections D.8, D.9, D.10 and D.13 are implemented. Sections D.4, D.7, D.11, D.12, and D.14 remain undone.
.. [#note-P0883] P0883: shared_ptr and floating-point changes weren't applied as they themselves aren't implemented yet. .. [#note-P0883] P0883: shared_ptr and floating-point changes weren't applied as they themselves aren't implemented yet.
.. _issues-status-cxx20: .. _issues-status-cxx20:
Library Working Group Issues Status Library Working Group Issues Status
==================================== ====================================
.. csv-table:: .. csv-table::
:file: Cxx20Issues.csv :file: Cxx20Issues.csv
:header-rows: 1 :header-rows: 1
:widths: auto :widths: auto