[pseudo] Fix the incorrect parameters-and-qualifiers rule.

[hokein]

Summary

The parenthese body should be parameter-declaration-clause, rather
than parameter-declaration-list.

[hokein]

friendly ping.

clang-tools-extra/pseudo/test/glr.cpp

37 ↗

(On Diff #429001)

since we have the builtin pseudoCXX library now, we could use it to write a cxx unittest, so that we can get rid of this cxx lit test. what do you think? (I have a feeling we might add more in the future, I just discovered a new oversight in our cxx.bnf grammar).

[sammccall]

clang-tools-extra/pseudo/test/glr.cpp

37 ↗

(On Diff #429001)

For detailed coverage of particular parts, t's not obvious to me whether a unit test or these tests will be more readable. (Consider writing a bunch of matchers and dealing with the messages from those, vs textual diffs here).

37 ↗

(On Diff #429001)

can we place this test in another file? (glr/varargs.cpp or so)
I missed this with operator< but that should probably be its own file too.

One of the things that feels painful with clang's lit tests is having to reduce a failure in a huge file with many related tests.

[hokein]

pull out a separate test file.

clang-tools-extra/pseudo/lib/cxx.bnf

 declarator := ptr-declarator
 declarator := noptr-declarator parameters-and-qualifiers trailing-return-type
 ptr-declarator := noptr-declarator
 ptr-declarator := ptr-operator ptr-declarator
 noptr-declarator := declarator-id
 noptr-declarator := noptr-declarator parameters-and-qualifiers
 noptr-declarator := noptr-declarator [ constant-expression_opt ]
 noptr-declarator := ( ptr-declarator )
-parameters-and-qualifiers := ( parameter-declaration-list_opt ) cv-qualifier-seq_opt ref-qualifier_opt noexcept-specifier_opt
+parameters-and-qualifiers := ( parameter-declaration-clause_opt ) cv-qualifier-seq_opt ref-qualifier_opt noexcept-specifier_opt
 trailing-return-type := -> type-id
 ptr-operator := * cv-qualifier-seq_opt
 ptr-operator := &
 ptr-operator := &&
 ptr-operator := nested-name-specifier * cv-qualifier-seq_opt
 cv-qualifier-seq := cv-qualifier cv-qualifier-seq_opt
 cv-qualifier := CONST
 cv-qualifier := VOLATILE

clang-tools-extra/pseudo/test/cxx/parameter-decl-clause.cpp

+// RUN: clang-pseudo -grammar=%cxx-bnf-file -source=%s --print-forest | FileCheck %s
+void foo2(int, ...);
+// CHECK:      translation-unit~simple-declaration := decl-specifier-seq init-declarator-list ;
+// CHECK-NEXT: ├─decl-specifier-seq~VOID :=
+// CHECK-NEXT: ├─init-declarator-list~noptr-declarator := noptr-declarator parameters-and-qualifiers
+// CHECK-NEXT: │ ├─noptr-declarator~IDENTIFIER :=
+// CHECK-NEXT: │ └─parameters-and-qualifiers := ( parameter-declaration-clause )
+// CHECK-NEXT: │   ├─( :=
+// CHECK-NEXT: │   ├─parameter-declaration-clause := parameter-declaration-list , ...
+// CHECK-NEXT: │   │ ├─parameter-declaration-list~INT :=
+// CHECK-NEXT: │   │ ├─, :=
+// CHECK-NEXT: │   │ └─... :=
+// CHECK-NEXT: │   └─) :=
+// CHECK-NEXT: └─; :=

clang-tools-extra/pseudo/test/cxx/unsized-array.cpp

 // RUN: clang-pseudo -grammar=%cxx-bnf-file -source=%s --print-forest | FileCheck %s
 void s(int[]);
-// CHECK:      parameter-declaration-list~parameter-declaration := decl-specifier-seq abstract-declarator
+// CHECK:      parameter-declaration-clause~parameter-declaration := decl-specifier-seq abstract-declarator
 // CHECK-NEXT: ├─decl-specifier-seq~INT := tok[3]
 // CHECK-NEXT: └─abstract-declarator~noptr-abstract-declarator := [ ]
 // CHECK-NEXT:   ├─[ := tok[4]
 // CHECK-NEXT:   └─] := tok[5]