This is an archive of the discontinued LLVM Phabricator instance.

Differential D124873

[lldb] Session transcript should use the async debugger streams
ClosedPublic

Authored by JDevlieghere on May 3 2022, 1:34 PM.

Details

Reviewers
mib
Commits
rG3d08c778c01e: [lldb] Session transcript should use the async debugger streams
Summary

When writing out the session transcript, output should be printed to the async debugger streams.

Diff Detail

Event Timeline

JDevlieghere created this revision.May 3 2022, 1:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2022, 1:34 PM
JDevlieghere requested review of this revision.May 3 2022, 1:34 PM
mib accepted this revision.May 3 2022, 1:35 PM

LGTM! Thanks!

This revision is now accepted and ready to land.May 3 2022, 1:35 PM
JDevlieghere updated this revision to Diff 426821.May 3 2022, 1:35 PM

Typo

Harbormaster completed remote builds in B162546: Diff 426821.May 3 2022, 1:38 PM
Closed by commit rG3d08c778c01e: [lldb] Session transcript should use the async debugger streams (authored by JDevlieghere). · Explain WhyMay 3 2022, 3:12 PM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rG3d08c778c01e: [lldb] Session transcript should use the async debugger streams.
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2022, 3:12 PM

Revision Contents

PathSize
lldb/
source/
Core/
4 lines

Diff 426856

lldb/source/Core/Debugger.cpp

Show First 20 Lines • Show All 663 Lines • ▼ Show 20 Lines if (!debugger_sp)
return; return;
CommandInterpreter &cmd_interpreter = debugger_sp->GetCommandInterpreter(); CommandInterpreter &cmd_interpreter = debugger_sp->GetCommandInterpreter();
if (cmd_interpreter.GetSaveSessionOnQuit()) { if (cmd_interpreter.GetSaveSessionOnQuit()) {
CommandReturnObject result(debugger_sp->GetUseColor()); CommandReturnObject result(debugger_sp->GetUseColor());
cmd_interpreter.SaveTranscript(result); cmd_interpreter.SaveTranscript(result);
if (result.Succeeded()) if (result.Succeeded())
debugger_sp->GetOutputStream() << result.GetOutputData() << '\n'; (*debugger_sp->GetAsyncOutputStream()) << result.GetOutputData() << '\n';
else else
debugger_sp->GetErrorStream() << result.GetErrorData() << '\n'; (*debugger_sp->GetAsyncErrorStream()) << result.GetErrorData() << '\n';
} }
debugger_sp->Clear(); debugger_sp->Clear();
if (g_debugger_list_ptr && g_debugger_list_mutex_ptr) { if (g_debugger_list_ptr && g_debugger_list_mutex_ptr) {
std::lock_guard<std::recursive_mutex> guard(*g_debugger_list_mutex_ptr); std::lock_guard<std::recursive_mutex> guard(*g_debugger_list_mutex_ptr);
DebuggerList::iterator pos, end = g_debugger_list_ptr->end(); DebuggerList::iterator pos, end = g_debugger_list_ptr->end();
for (pos = g_debugger_list_ptr->begin(); pos != end; ++pos) { for (pos = g_debugger_list_ptr->begin(); pos != end; ++pos) {
▲ Show 20 Lines • Show All 1,290 Lines • Show Last 20 Lines