Fixes:
sanitizer_stack_store.cpp:257:13: warning: this statement may fall through [-Wimplicit-fallthrough=]
when being built with GCC.
Differential D124832
sanitizer: support GCC's fallthrough attribute marxin on May 3 2022, 1:55 AM. Authored by
Details
Fixes: when being built with GCC.
Diff Detail
Event TimelineComment Actions It caused: /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_stack_store.cpp:258:7: error: use of the 'fallthrough' attribute is a C++17 extension [-Werror,-Wc++17-attribute-extensions] FALLTHROUGH; ^ b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common../sanitizer_common/sanitizer_internal_defs.h:263:25: note: expanded from macro 'FALLTHROUGH' # define FALLTHROUGH [[fallthrough]] Which is similar to: The warning is misleading as it's guarded in __has_cpp_attribute. Comment Actions If this is a new warning, maybe reordering these will help: #if has_cpp_attribute(fallthrough) |