This is an archive of the discontinued LLVM Phabricator instance.

Differential D124609

Add unit test with invariant store for vectorizer memory runtime checks
ClosedPublic

Authored by igor.kirillov on Apr 28 2022, 5:47 AM.

Details

Reviewers
fhahn
Commits
rT2a41ecd23309: Add unit test with invariant store for vectorizer memory runtime checks
Summary

The test is for the functionality implemented in
https://reviews.llvm.org/D110235

Diff Detail

Repository
rT test-suite

Event Timeline

igor.kirillov created this revision.Apr 28 2022, 5:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2022, 5:47 AM
igor.kirillov requested review of this revision.Apr 28 2022, 5:47 AM
Harbormaster completed remote builds in B161779: Diff 425755.Apr 28 2022, 5:47 AM
igor.kirillov added a reviewer: fhahn.Apr 28 2022, 5:49 AM
igor.kirillov mentioned this in D110235: [LoopVectorize] Support reductions that store intermediary result.Apr 28 2022, 5:54 AM
fhahn accepted this revision.May 2 2022, 1:10 PM

LGTM, thanks!

SingleSource/UnitTests/Vectorizer/runtime-checks.cpp
246

nit: indent seems off a bit here.

251

nit: might be good to include invariant store or something in the string.

This revision is now accepted and ready to land.May 2 2022, 1:10 PM
igor.kirillov updated this revision to Diff 426618.May 3 2022, 2:36 AM

Address 'nits' requests

Harbormaster completed remote builds in B162399: Diff 426618.May 3 2022, 2:36 AM
igor.kirillov marked 2 inline comments as done.May 3 2022, 3:31 AM
Closed by commit rT2a41ecd23309: Add unit test with invariant store for vectorizer memory runtime checks (authored by igor.kirillov). · Explain WhyMay 5 2022, 12:18 AM
This revision was automatically updated to reflect the committed changes.
igor.kirillov added a commit: rT2a41ecd23309: Add unit test with invariant store for vectorizer memory runtime checks.

Revision Contents

PathSize
SingleSource/
UnitTests/
Vectorizer/
16 lines
3 lines

Diff 427220

SingleSource/UnitTests/Vectorizer/runtime-checks.cpp

Show First 20 Lines • Show All 234 Lines • ▼ Show 20 Lines rng = std::mt19937(15);
checkOverlappingMemoryOneRuntimeCheck<uint32_t>( checkOverlappingMemoryOneRuntimeCheck<uint32_t>(
ScalarFn, VectorFn, "1 read, 1 write, induction increment 2, uint32_t"); ScalarFn, VectorFn, "1 read, 1 write, induction increment 2, uint32_t");
checkOverlappingMemoryOneRuntimeCheck<uint64_t>( checkOverlappingMemoryOneRuntimeCheck<uint64_t>(
ScalarFn, VectorFn, ScalarFn, VectorFn,
"1 read, 1 write, induction increment 2, uint64_t"); "1 read, 1 write, induction increment 2, uint64_t");
} }
{ {
DEFINE_SCALAR_AND_VECTOR_FN2(
for (unsigned i = 0, sum = 0; i < TC; i++) {
sum += A[i] + 10;
B[TC / 2] = sum;
fhahnUnsubmitted
Done
ReplyInline Actions

nit: indent seems off a bit here.

fhahn: nit: indent seems off a bit here.
}
);
checkOverlappingMemoryOneRuntimeCheck<uint8_t>(
ScalarFn, VectorFn, "1 read, 1 write to invariant address, step 1, uint8_t");
fhahnUnsubmitted
Done
ReplyInline Actions

nit: might be good to include invariant store or something in the string.

fhahn: nit: might be good to include invariant store or something in the string.
checkOverlappingMemoryOneRuntimeCheck<uint32_t>(
ScalarFn, VectorFn, "1 read, 1 write to invariant address, step 1, uint32_t");
checkOverlappingMemoryOneRuntimeCheck<uint64_t>(
ScalarFn, VectorFn, "1 read, 1 write to invariant address, step 1, uint64_t");
}
{
DEFINE_SCALAR_AND_VECTOR_FN3( DEFINE_SCALAR_AND_VECTOR_FN3(
for (unsigned i = 0; i < TC; i++) for (unsigned i = 0; i < TC; i++)
A[i] = B[i] + C[i] + 10; A[i] = B[i] + C[i] + 10;
); );
checkOverlappingMemoryTwoRuntimeChecks<uint32_t>( checkOverlappingMemoryTwoRuntimeChecks<uint32_t>(
ScalarFn, VectorFn, "2 reads, 1 write, simple indices, uint32_t"); ScalarFn, VectorFn, "2 reads, 1 write, simple indices, uint32_t");
checkOverlappingMemoryTwoRuntimeChecks<uint8_t>( checkOverlappingMemoryTwoRuntimeChecks<uint8_t>(
Show All 24 Lines

SingleSource/UnitTests/Vectorizer/runtime-checks.reference_output

Show All 13 Lines
Checking 1 read, 1 write, index count down 2, uint32_t Checking 1 read, 1 write, index count down 2, uint32_t
Checking 1 read, 1 write, index count down 2, uint64_t Checking 1 read, 1 write, index count down 2, uint64_t
Checking 1 read, 1 write, 2 inductions, different steps, uint8_t Checking 1 read, 1 write, 2 inductions, different steps, uint8_t
Checking 1 read, 1 write, 2 inductions, different steps, uint32_t Checking 1 read, 1 write, 2 inductions, different steps, uint32_t
Checking 1 read, 1 write, 2 inductions, different steps, uint64_t Checking 1 read, 1 write, 2 inductions, different steps, uint64_t
Checking 1 read, 1 write, induction increment 2, uint8_t Checking 1 read, 1 write, induction increment 2, uint8_t
Checking 1 read, 1 write, induction increment 2, uint32_t Checking 1 read, 1 write, induction increment 2, uint32_t
Checking 1 read, 1 write, induction increment 2, uint64_t Checking 1 read, 1 write, induction increment 2, uint64_t
Checking 1 read, 1 write to invariant address, step 1, uint8_t
Checking 1 read, 1 write to invariant address, step 1, uint32_t
Checking 1 read, 1 write to invariant address, step 1, uint64_t
Checking 2 reads, 1 write, simple indices, uint32_t Checking 2 reads, 1 write, simple indices, uint32_t
Checking 2 reads, 1 write, simple indices, uint8_t Checking 2 reads, 1 write, simple indices, uint8_t
Checking 2 reads, 1 write, simple indices, uint64_t Checking 2 reads, 1 write, simple indices, uint64_t
Checking 1 read, 2 writes, simple indices, uint8_t Checking 1 read, 2 writes, simple indices, uint8_t
Checking 1 read, 2 writes, simple indices, uint32_t Checking 1 read, 2 writes, simple indices, uint32_t
Checking 1 read, 2 writes, simple indices, uint64_t Checking 1 read, 2 writes, simple indices, uint64_t
exit 0 exit 0