Avoid usage of F_DUPFD_CLOEXEC where not available (e.g. kfreebsd*)

[sylvestre.ledru]

Summary

kfreebsd doesn't have F_DUPFD_CLOEXEC, so use it conditionally.

Author: Emilio Pozuelo Monfort <[e-mail]>
Author: Petr Salinger <[e-mail]>
Author: Gianfranco Costamagna

[emaste]

source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp

472

Properly kFreeBSD, no?

[sylvestre.ledru]

Fix the typo (thanks)

[emaste]

Although, is there a reason kFreeBSD doesn't have F_DUPFD_CLOEXEC?

[sylvestre.ledru]

Nope, KFreeBSD will have it in the next version

source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp

ProcessFreeBSD::DoLaunch (Module *module,
     m_module = module;
 
     if (!error.Success())
         return error;
 
     int terminal = m_monitor->GetTerminalFD();
     if (terminal >= 0) {
         // The reader thread will close the file descriptor when done, so we pass it a copy.
+#ifdef F_DUPFD_CLOEXEC
         int stdio = fcntl(terminal, F_DUPFD_CLOEXEC, 0);
         if (stdio == -1) {
             error.SetErrorToErrno();
             return error;
         }
+#else
+        // Special case when F_DUPFD_CLOEXEC does not exist (Debian kFreeBSD)
+        int stdio = fcntl(terminal, F_DUPFD, 0);
+        if (stdio == -1) {
+            error.SetErrorToErrno();
+            return error;
+        }
+        stdio = fcntl(terminal, F_SETFD, FD_CLOEXEC);
+        if (stdio == -1) {
+            error.SetErrorToErrno();
+            return error;
+        }
+#endif
         SetSTDIOFileDescriptor(stdio);
     }
 
     SetID(m_monitor->GetPID());
     return error;
 }
 
 void