This is an archive of the discontinued LLVM Phabricator instance.

Differential D124030

[ASan] Removed checks if the tested functions were emitted.
ClosedPublic

Authored by kstoimenov on Apr 19 2022, 12:01 PM.

Details

Reviewers
eugenis
Commits
rGab99a414ef95: [ASan] Removed checks if the tested functions were emitted.

Diff Detail

Event Timeline

kstoimenov created this revision.Apr 19 2022, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2022, 12:01 PM
kstoimenov requested review of this revision.Apr 19 2022, 12:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2022, 12:01 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
eugenis accepted this revision.Apr 19 2022, 12:02 PM
This revision is now accepted and ready to land.Apr 19 2022, 12:02 PM
kstoimenov mentioned this in D123643: [ASan] Fixed a reporting bug in (load|store)N functions which would print unknown-crash instead of the proper error message when a the data access is unaligned..Apr 19 2022, 12:03 PM
kstoimenov retitled this revision from [ASan] Removed checks if the tested functions where emitted. to [ASan] Removed checks if the tested functions were emitted..
This revision was landed with ongoing or failed builds.Apr 19 2022, 12:21 PM
Closed by commit rGab99a414ef95: [ASan] Removed checks if the tested functions were emitted. (authored by kstoimenov). · Explain Why
This revision was automatically updated to reflect the committed changes.
kstoimenov added a commit: rGab99a414ef95: [ASan] Removed checks if the tested functions were emitted..
Harbormaster completed remote builds in B160297: Diff 423698.Apr 19 2022, 12:24 PM

Revision Contents

PathSize
compiler-rt/
test/
asan/
TestCases/
14 lines

Diff 423704

compiler-rt/test/asan/TestCases/load_and_store_n.cpp

// CHECK_REGULAR_LOAD_STORE: call void @__asan_loadN
// CHECK_REGULAR_LOAD_STORE: call void @__asan_storeN
// RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o %t // RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o %t
// RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o - -S \
// RUN: -emit-llvm | FileCheck %s --check-prefix=CHECK_REGULAR_LOAD_STORE
// RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES // RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES
// RUN: not %run %t B 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES // RUN: not %run %t B 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES
// RUN: not %run %t C 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES // RUN: not %run %t C 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES
// RUN: not %run %t D 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES // RUN: not %run %t D 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES
// CHECK_NOABORT_LOAD_STORE: call void @__asan_loadN_noabort
// CHECK_NOABORT_LOAD_STORE: call void @__asan_storeN_noabort
// RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o %t \ // RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o %t \
// RUN: -mllvm -asan-recover=1 // RUN: -mllvm -asan-recover=1
// RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o - -S \
// RUN: -mllvm -asan-recover=1 -emit-llvm \
// RUN: | FileCheck %s --check-prefix=CHECK_NOABORT_LOAD_STORE
// RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES // RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES
// RUN: not %run %t B 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES // RUN: not %run %t B 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES
// RUN: not %run %t C 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES // RUN: not %run %t C 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES
// RUN: not %run %t D 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES // RUN: not %run %t D 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES
// CHECK_EXP_LOAD_STORE: call void @__asan_exp_loadN
// CHECK_EXP_LOAD_STORE: call void @__asan_exp_storeN
// RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o %t \ // RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o %t \
// RUN: -mllvm -asan-force-experiment=42 // RUN: -mllvm -asan-force-experiment=42
// RUN: %clangxx_asan -O2 -fsanitize-address-outline-instrumentation %s -o - -S \
// RUN: -mllvm -asan-force-experiment=42 -emit-llvm \
// RUN: | FileCheck %s --check-prefix=CHECK_EXP_LOAD_STORE
// RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES // RUN: not %run %t A 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES
// RUN: not %run %t B 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES // RUN: not %run %t B 2>&1 | FileCheck %s --check-prefix=CHECK_0_BYTES
// RUN: not %run %t C 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES // RUN: not %run %t C 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES
// RUN: not %run %t D 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES // RUN: not %run %t D 2>&1 | FileCheck %s --check-prefix=CHECK_1_BYTES
// CHECK_0_BYTES: ERROR: AddressSanitizer: global-buffer-overflow on address [[ADDR:.*]] at // CHECK_0_BYTES: ERROR: AddressSanitizer: global-buffer-overflow on address [[ADDR:.*]] at
// CHECK_0_BYTES: [[ADDR]] is located 0 bytes to the right // CHECK_0_BYTES: [[ADDR]] is located 0 bytes to the right
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines