Page MenuHomePhabricator

[OCaml][DebugInfo] Add bindings for parameter and auto variable creation
ClosedPublic

Authored by vaivaswatha on Apr 17 2022, 8:42 AM.

Details

Summary

This patch extends https://reviews.llvm.org/D90831 with a few more functions added to the OCaml debuginfo bindings.

Diff Detail

Event Timeline

vaivaswatha created this revision.Apr 17 2022, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2022, 8:42 AM
vaivaswatha requested review of this revision.Apr 17 2022, 8:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2022, 8:42 AM
jberdine accepted this revision.Apr 23 2022, 1:12 PM

LGTM, though I would prefer if docstrings were added for each of the functions added to llvm_debuginfo.mli.

This revision is now accepted and ready to land.Apr 23 2022, 1:12 PM

Add inline docs for the newly added functions in the .mli file.

LGTM, though I would prefer if docstrings were added for each of the functions added to llvm_debuginfo.mli.

Thank you @jberdine . I have now added the docstrings (it had skipped my mind entirely, thank you for noticing).

This revision was landed with ongoing or failed builds.Apr 23 2022, 11:42 PM
This revision was automatically updated to reflect the committed changes.