Page MenuHomePhabricator

Misc cleanups re-commandeered from D11963.
ClosedPublic

Authored by jroelofs on Aug 24 2015, 2:07 PM.

Details

Reviewers
EricWF
Summary

This separates out the bits of D11963 which were drive-by fixes, which aren't really relevant to the __config_site part of that change.

Diff Detail

Event Timeline

jroelofs updated this revision to Diff 32995.Aug 24 2015, 2:07 PM
jroelofs retitled this revision from to Misc cleanups re-commandeered from D11963..
jroelofs updated this object.
jroelofs added a reviewer: EricWF.
jroelofs added a subscriber: cfe-commits.
jroelofs updated this revision to Diff 32996.Aug 24 2015, 2:10 PM

The diff uploaded strangely... trying again.

EricWF edited edge metadata.Aug 24 2015, 2:11 PM

Can you move the libcpp-has-no-threads tests to test/libcxx/atomics instead of deleting them? (I imagine that's what you intended to do).

Also tested_elsewhere.pass.cpp shouldn't really be called that because it contains the actual test. Could you rename it to something?

EricWF accepted this revision.Aug 24 2015, 2:14 PM
EricWF edited edge metadata.

LGTM after renaming tested_elsewhere.pass.cpp

This revision is now accepted and ready to land.Aug 24 2015, 2:14 PM

Actually commit this as is and I'll handle the other cleanup.

jroelofs closed this revision.Aug 24 2015, 2:21 PM

r245876