This is an archive of the discontinued LLVM Phabricator instance.

[libc++][libc++abi] Serialize the enable_assertions Lit parameter in the generated config
ClosedPublic

Authored by ldionne on Mar 28 2022, 10:12 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Restricted Project
Commits
rG65b1b3b961cf: [libc++][libc++abi] Serialize the enable_assertions Lit parameter in the…
Summary

This means that re-running with llvm-lit in that configuration will
work as expected. This also enables assertions in libc++abi in the
Generic-assertions CI job, which was disabled previously.

Diff Detail

Event Timeline

ldionne created this revision.Mar 28 2022, 10:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2022, 10:12 AM
Herald added a subscriber: mgorny. · View Herald Transcript
ldionne requested review of this revision.Mar 28 2022, 10:12 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 28 2022, 10:12 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision as: Restricted Project, Restricted Project.Mar 29 2022, 5:17 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2022, 5:17 AM
This revision was automatically updated to reflect the committed changes.