This is an archive of the discontinued LLVM Phabricator instance.

Reorg code to allow Windows Process Plugins to share some common code.
ClosedPublic

Authored by amccarth on Aug 21 2015, 3:54 PM.

Details

Summary

In order to share some code between normal Windows debugging and Windows mini dump debugging, this is just a shuffling of files into a different hierarchy.

source/Plugins/Process/Windows/Common

Common code for the two Windows Process Plugins.  Currently, this is just ExceptionRecord.h, but I expect this to grow as the mini dump plugin is fleshed out.  This code cannot live at a higher level (e.g., in Process/Utility) because it includes Windows-specific files.

source/Plugins/Process/Windows/Live

Code for normal Windows debugging.  This used to be one level higher.

source/Plugins/Process/Windows/MiniDump

Code for mini dump debugging.

Other than moving files, this includes a few necessary tweaks to CMakeLists and #include statements to reflect the new hierarchy.

Diff Detail

Event Timeline

amccarth updated this revision to Diff 32876.Aug 21 2015, 3:54 PM
amccarth retitled this revision from to Reorg code to allow Windows Process Plugins to share some common code..
amccarth updated this object.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
zturner accepted this revision.Aug 21 2015, 3:56 PM
zturner edited edge metadata.

Looks good. I'm guessing that at some point the RegisterContext and ExceptionRecord stuff will be moved to Common?

This revision is now accepted and ready to land.Aug 21 2015, 3:56 PM
This revision was automatically updated to reflect the committed changes.
source/Plugins/Process/win-minidump/ThreadWinMiniDump.h