Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.

[sas]

Summary

This commit implements basic DidAttach and DidLaunch for the windows
DynamicLoader plugin which allow us to load shared libraries from the
inferior.

At the moment, I'm unsure how we're going to gather the load address of
the main module over gdb protocol so I always use an offset of 0, which
works well for processes we create ourselves (no randomization). I will
address this point later on.

[clayborg]

Fine for now.

[zturner]

Can you verify that this does not break local debugging on Windows?

[sas]

Style.

[sas]

@zturner, will do before submitting.

[zturner]

Tested on Windows, I don't see any problems, so lgtm.

If you're going to be doing a non-trivial amount of work on ProcessWindows
or DynamicLoaderWindows, would it be possible for you to set up a Windows
box you can test from? I'm happy to help you get this set up if you need.

[sas]

Thanks for the testing. I'll definitely setup a windows box.

[zturner]

Hi Stephane, I'm sorry but I had to revert this change. When I tested it
locally, I did it without running the full test suite, but when I did run
the full test suite it showed about 15-20 new test failures. I should have
caught this earlier by running the full test suite, so sorry about that.

I'm not 100% sure what the cause of the failure is, but I suspect it could
be related to DynamicLoaderWindows adding modules to the list *and*
ProcessWindows adding modules to the list as well.

If you need help setting up a Windows machine to test this on let me know.
Unfortunately it's not that trivial, but luckily once you get it set up and
correctly configured it becomes pretty easy to keep it going smoothly.

Let me know if you need more information.

[zturner]

By the way, I'm actively working on getting the test suite completely
running on a buildbot, but I need to get down to a green baseline first.
Still a few weeks out, but hopefully this type of thing will be caught
automatically in the future.

[sas]

Not a problem at all. Sorry for breaking the tests.

I'm setting up a Windows VM now to be able to run these tests. I'll let you know if I'm stuck.

[zturner]

Hi Stephane, what's the status of this? Do you still need this functionality?

source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp

 //===-- DynamicLoaderWindowsDYLD.cpp --------------------------------*- C++ -*-===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "DynamicLoaderWindowsDYLD.h"
 
+#include "lldb/Core/Log.h"
 #include "lldb/Core/PluginManager.h"
 #include "lldb/Target/Process.h"
 #include "lldb/Target/Target.h"
 
 #include "llvm/ADT/Triple.h"
 
 using namespace lldb;
 using namespace lldb_private;
if (should_create)
         return new DynamicLoaderWindowsDYLD(process);
 
     return nullptr;
 }
 
 void
 DynamicLoaderWindowsDYLD::DidAttach()
 {
+    Log *log (GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER));
+    if (log)
+        log->Printf ("DynamicLoaderWindowsDYLD::%s()", __FUNCTION__);
+
+    DidLaunch();
+
+    m_process->LoadModules();
 }
 
 void
 DynamicLoaderWindowsDYLD::DidLaunch()
 {
+    Log *log (GetLogIfAnyCategoriesSet(LIBLLDB_LOG_DYNAMIC_LOADER));
+    if (log)
+        log->Printf ("DynamicLoaderWindowsDYLD::%s()", __FUNCTION__);
+
+    ModuleSP executable = GetTargetExecutable();
+
+    if (!executable.get())
+      return;
+
+    ModuleList module_list;
+    module_list.Append(executable);
+    // FIXME: We probably should not always use 0 as the load address
+    // here. Testing showed that when debugging a process that we start
+    // ourselves, there's no randomization of the load address of the
+    // main module, therefore an offset of 0 will be valid.
+    // If we attach to an already running process, this is probably
+    // going to be wrong and we'll have to get the load address somehow.
+    UpdateLoadedSections(executable, LLDB_INVALID_ADDRESS, 0);
+
+    m_process->GetTarget().ModulesDidLoad(module_list);
 }
 
 Error
 DynamicLoaderWindowsDYLD::CanLoadImage()
 {
     return Error();
 }