Page MenuHomePhabricator

[NVPTX] Allow undef value as global initializer
ClosedPublic

Authored by wengxt on Aug 21 2015, 9:53 AM.

Details

Summary

shared variable may now emit undef value as initializer, do not
throw error on that.

Test Plan: test/CodeGen/NVPTX/global-addrspace.ll

Patch by Xuetian Weng

Diff Detail

Event Timeline

wengxt updated this revision to Diff 32837.Aug 21 2015, 9:53 AM
wengxt retitled this revision from to [NVPTX] Allow undef value as global initializer.
wengxt updated this object.
wengxt added reviewers: jingyue, jholewinski.
wengxt added a subscriber: llvm-commits.
jingyue accepted this revision.Aug 21 2015, 10:10 AM
jingyue edited edge metadata.

I should commit this one before your Clang change, right?

lib/Target/NVPTX/NVPTXAsmPrinter.cpp
1186

Please update the comments.

This revision is now accepted and ready to land.Aug 21 2015, 10:10 AM
wengxt updated this revision to Diff 32846.Aug 21 2015, 11:11 AM
wengxt edited edge metadata.

update comments.

wengxt marked an inline comment as done.Aug 21 2015, 11:12 AM
jingyue updated this object.Aug 21 2015, 10:40 PM
jingyue closed this revision.Aug 21 2015, 10:41 PM