This is an archive of the discontinued LLVM Phabricator instance.

Differential D12242

[NVPTX] Allow undef value as global initializer
ClosedPublic

Authored by wengxt on Aug 21 2015, 9:53 AM.

Details

Reviewers
jholewinski
tra
jingyue
Commits
rGfcec09866a12: [NVPTX] Allow undef value as global initializer
rL245785: [NVPTX] Allow undef value as global initializer
Summary

shared variable may now emit undef value as initializer, do not
throw error on that.

Test Plan: test/CodeGen/NVPTX/global-addrspace.ll

Patch by Xuetian Weng

Diff Detail

Event Timeline

wengxt updated this revision to Diff 32837.Aug 21 2015, 9:53 AM
wengxt retitled this revision from to [NVPTX] Allow undef value as global initializer.
wengxt updated this object.
wengxt added reviewers: jingyue, jholewinski.
wengxt added a subscriber: llvm-commits.
Herald added a subscriber: jholewinski. · View Herald TranscriptAug 21 2015, 9:53 AM
wengxt added a child revision: D12241: [CUDA] Change initializer for CUDA device code based on CUDA documentation..Aug 21 2015, 9:54 AM
jingyue added a reviewer: tra.Aug 21 2015, 10:09 AM

+Artem

jingyue accepted this revision.Aug 21 2015, 10:10 AM
jingyue edited edge metadata.

I should commit this one before your Clang change, right?

lib/Target/NVPTX/NVPTXAsmPrinter.cpp
1186

Please update the comments.

This revision is now accepted and ready to land.Aug 21 2015, 10:10 AM
wengxt updated this revision to Diff 32846.Aug 21 2015, 11:11 AM
wengxt edited edge metadata.

update comments.

wengxt marked an inline comment as done.Aug 21 2015, 11:12 AM
jingyue updated this object.Aug 21 2015, 10:40 PM
jingyue closed this revision.Aug 21 2015, 10:41 PM

Revision Contents

PathSize
lib/
Target/
NVPTX/
3 lines
test/
CodeGen/
NVPTX/
12 lines

Diff 32837

lib/Target/NVPTX/NVPTXAsmPrinter.cpp

Show First 20 Lines • Show All 1,177 Lines • ▼ Show 20 Lines if (GVar->hasInitializer()) {
(PTy->getAddressSpace() == llvm::ADDRESS_SPACE_CONST)) { (PTy->getAddressSpace() == llvm::ADDRESS_SPACE_CONST)) {
const Constant *Initializer = GVar->getInitializer(); const Constant *Initializer = GVar->getInitializer();
// 'undef' is treated as there is no value specified. // 'undef' is treated as there is no value specified.
if (!Initializer->isNullValue() && !isa<UndefValue>(Initializer)) { if (!Initializer->isNullValue() && !isa<UndefValue>(Initializer)) {
O << " = "; O << " = ";
printScalarConstant(Initializer, O); printScalarConstant(Initializer, O);
} }
} else { } else {
// The frontend adds zero-initializer to variables that don't have an // The frontend adds zero-initializer to variables that don't have an
jingyueUnsubmitted
Done
ReplyInline Actions

Please update the comments.

jingyue: Please update the comments.
// initial value, so skip warning for this case. // initial value, so skip warning for this case.
if (!GVar->getInitializer()->isNullValue()) { if (!GVar->getInitializer()->isNullValue() &&
!isa<UndefValue>(GVar->getInitializer())) {
report_fatal_error("initial value of '" + GVar->getName() + report_fatal_error("initial value of '" + GVar->getName() +
"' is not allowed in addrspace(" + "' is not allowed in addrspace(" +
Twine(PTy->getAddressSpace()) + ")"); Twine(PTy->getAddressSpace()) + ")");
} }
} }
} }
} else { } else {
unsigned int ElementSize = 0; unsigned int ElementSize = 0;
▲ Show 20 Lines • Show All 1,164 Lines • Show Last 20 Lines

test/CodeGen/NVPTX/global-addrspace.ll

  • This file was added.
; RUN: llc < %s -march=nvptx -mcpu=sm_20 | FileCheck %s --check-prefix=PTX32
; RUN: llc < %s -march=nvptx64 -mcpu=sm_20 | FileCheck %s --check-prefix=PTX64
; PTX32: .visible .global .align 4 .u32 i;
; PTX32: .visible .const .align 4 .u32 j;
; PTX32: .visible .shared .align 4 .u32 k;
; PTX64: .visible .global .align 4 .u32 i;
; PTX64: .visible .const .align 4 .u32 j;
; PTX64: .visible .shared .align 4 .u32 k;
@i = addrspace(1) externally_initialized global i32 0, align 4
@j = addrspace(4) externally_initialized global i32 0, align 4
@k = addrspace(3) global i32 undef, align 4